-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogMessage Suggestion #31
Comments
I'm not sure that I understand the purpose of these suggestions re |
Well... like I said, it's not critical, but as a simple example, I can't easily unit test my formatter because I can't create
Given that By extended I meant inheriting from Again, just suggestions. |
|
Hi,
Thanks for this little library.
I just have two minor suggestions regarding
LogMessage
.The first is to consider making it a class. Perhaps there's a reason you can't use a class(?), but as a struct we can't extend it, and structs holding reference types can cause some difficulties to those who are unaware (remember that
Exception
is mutable).The second is to make the constructor public (it's currently
internal
), or simply delete it entirely, so we can createLogMessage
s in our code. Without this, refactoring sometimes gets more awkward than it needs to be.Neither are at all critical but just something to consider for next time you work on the library.
Thanks again
The text was updated successfully, but these errors were encountered: