Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adonis 4.x Support #12

Merged
merged 2 commits into from
Nov 24, 2017
Merged

Adonis 4.x Support #12

merged 2 commits into from
Nov 24, 2017

Conversation

enniel
Copy link
Contributor

@enniel enniel commented Nov 22, 2017

No description provided.

@enniel enniel mentioned this pull request Nov 23, 2017
@nrempel
Copy link
Owner

nrempel commented Nov 24, 2017

This looks fantastic! Thank you very much for helping with this.

I'm going to merge this right away because there are no blockers here but can you address a couple things in a new pull request if you have time?

  • Can you remove package-lock.json from .gitignore?
  • Feel free to add a CONTRIBUTORS.md file and add yourself 😄
  • The tests pass but I'm not sure why this fails. I added a repo in coveralls but it still fails: https://coveralls.io/github/nrempel/adonis-kue
> nyc report --reporter=text-lcov | coveralls


/Users/nbrempel/Projects/adonis-kue/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}

I'm going to publish this as a new major version to npm.

I'm also going to make you a contributor @enniel so please feel free to make any improvements you like. Just create an issue if you would like me to publish a new version to npm!

@enniel
Copy link
Contributor Author

enniel commented Nov 24, 2017

@nrempel You must create .coveralls.yml with code:

repo_token: <your token>

https://github.com/nickmerwin/node-coveralls#running-locally

@enniel enniel deleted the adonis-4.x branch July 25, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants