Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/load gpx track #240

Merged
merged 6 commits into from
Oct 8, 2019
Merged

Conversation

matzepan
Copy link
Contributor

@matzepan matzepan commented Oct 1, 2019

Added the ability to load tracks (kml, gpx, geojson, json) using leaflet-filelayer and display them as new Overlay layer.
Addresses: #30

Use leaflet-filelayer to load kml, gpx, geojson, json tracks and display them as new Overlay layer.
@bagage
Copy link
Collaborator

bagage commented Oct 1, 2019

Hey @matzepan, welcome aboard! Thanks for your contribution, it is one of the most asked-for feature. From what I've seen it's looking good, albeit a minor issue: it looks like tracks are declared as interactive layers but it seems they are not:

Capture d’écran vidéo de 01-10-2019 19:27:32_cropped

Good work!

@matzepan
Copy link
Contributor Author

matzepan commented Oct 1, 2019

@bagage this is also a feature that I wanted badly.
I changed the loaded track to be not interactive.
Thank you for your feedback.

@Phyks
Copy link
Contributor

Phyks commented Oct 2, 2019

What about keeping the loaded track in a URL parameter for easy sharing of the full view? For instance by encoding the polyline with mapbox/polyline in a track (tracks?) GET parameter similarly to #233 (which I should finish by the way)?

@matzepan
Copy link
Contributor Author

matzepan commented Oct 7, 2019

@Phyks I don't know if it makes sense to put these into the URL. Especially if this means blowing up the URL length.

@Phyks
Copy link
Contributor

Phyks commented Oct 7, 2019

It makes sense to have it to easy share the view with someone else / another computer. But indeed it probably does not make sense to have it in the URL and risk blowing the URL length.

Maybe BRouter-web should have something like Overpass to shorten links and share easily (including custom profiles, etc).

@nrenner nrenner merged commit 90dfa5b into nrenner:master Oct 8, 2019
@nrenner
Copy link
Owner

nrenner commented Oct 8, 2019

Great contribution, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants