-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with new Clojurescript releases (>0.0.2755) #44
Conversation
opts (assoc opts | ||
:ups-libs (:libs ups-deps) | ||
:ups-foreign-libs (:foreign-libs ups-deps)) | ||
compiler-env (env/default-compiler-env opts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@the-kenny not sure if plain assoc
is the right thing here. Potentially users might want to influence what's in behind these keywords?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - I haven't thought of this. Fix incoming.
Looking good! ✋ |
#37 only partially - in |
@the-kenny Actually, if you add:
to your project.clj, the |
The necessary fix for Clojurescript is now in master - we can merge this with the next Clojurescript-release (we just need to bump the version in |
Thanks for this! I'll review in a few hours and if it all looks good I'll merge with the next ClojureScript release. |
Looks great to me! Works splendidly with Clojurescript master. Once they cut a release I'll merge this and release with the appropriate dependencies bumped. |
I found that passing the system classloader to get-upstream-deps fixes this: #45 |
@bonkydog That's exactly what this pull request does. We're just waiting for a new Clojurescript release. I implemented both at the same time. |
Fix compatibility with new Clojurescript releases (>0.0.2755)
Thanks again for this! I've put a |
Sweet! Thanks! On Mon, Feb 9, 2015 at 6:09 PM, Tom Jakubowski notifications@github.com
|
The last few Clojurescript releases broke weasel when requiring namespaces. This patch backports necessary changes from
cljs.browser.repl
to weasel.1992a25 gathers upstream (js) dependencies and passes them down to the compiler. Same approach as clojure/clojurescript@5a353c4#diff-0e96f4c891374eb4ed736a5bdbb1b07dR273
74aa18e monkey-patches
goog.require
to be a no-op, like clojure/clojurescript@5a353c4#diff-c706571c79101d1f03c9f7073570741eR112This fixes #43 - but depends on a clojurescript-release containing http://dev.clojure.org/jira/browse/CLJS-1002 (which isn't fixed yet). This is necessary because weasel runs
cljs.closure/get-upstream-deps
from a non-main thread & the function uses the current Thread's classloader. The JIRA-ticket makesget-upstream-deps
take an optional argument which is then used as the classloader.