Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluetooth: controller: Fix unexpected low TX power with FEM connected #10143

Merged
merged 2 commits into from
Feb 7, 2023
Merged

bluetooth: controller: Fix unexpected low TX power with FEM connected #10143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1de202a
bluetooth: controller: Fix unexpected low TX power with FEM connected
rugeGerritsen Feb 2, 2023
7fa731e
doc: known_issues: Add known issue for BT_CTLR_TX_PWR_ANTENNA
rugeGerritsen Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/nrf/known_issues.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2212,6 +2212,11 @@ SoftDevice Controller

In addition to the known issues listed here, see also :ref:`softdevice_controller_limitations` for permanent limitations.

.. rst-class:: v2-2-0 v2-1-3 v2-1-2 v2-1-1 v2-1-0

DRGN-18568: When the :kconfig:option:`CONFIG_MPSL_FEM` Kconfig option is used, the actual value of radio output power is lower than expected.
The actual value is lower than the default one in case the :kconfig:option:`CONFIG_BT_CTLR_TX_PWR_ANTENNA` or :kconfig:option:`CONFIG_BT_CTLR_TX_PWR` Kconfig options are used together with the :kconfig:option:`CONFIG_MPSL_FEM` Kconfig option.

.. rst-class:: v2-2-0 v2-1-3 v2-1-2 v2-1-1 v2-1-0 v2-0-2 v2-0-1 v2-0-0 v1-9-2 v1-9-1 v1-9-0 v1-8-0

DRGN-16013: Initiating connections over extended advertising is not supported when external radio coexistence and FEM support are enabled
Expand Down
15 changes: 8 additions & 7 deletions subsys/bluetooth/controller/hci_driver.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,13 +612,6 @@ static int configure_supported_features(void)
}
}

#if RADIO_TXP_DEFAULT != 0
err = sdc_default_tx_power_set(RADIO_TXP_DEFAULT);
if (err) {
return -ENOTSUP;
}
#endif

if (IS_ENABLED(CONFIG_BT_CTLR_LE_POWER_CONTROL)) {
if (IS_ENABLED(CONFIG_BT_CENTRAL)) {
err = sdc_support_le_power_control_central();
Expand Down Expand Up @@ -851,6 +844,14 @@ static int hci_driver_open(void)
}
}

#if RADIO_TXP_DEFAULT != 0
err = sdc_default_tx_power_set(RADIO_TXP_DEFAULT);
if (err) {
MULTITHREADING_LOCK_RELEASE();
return -ENOTSUP;
}
#endif

err = sdc_enable(receive_signal_raise, sdc_mempool);
if (err) {
MULTITHREADING_LOCK_RELEASE();
Expand Down