Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: Mesh: Increase settings thread stack size #11180

Merged
merged 1 commit into from
May 19, 2023
Merged

Bluetooth: Mesh: Increase settings thread stack size #11180

merged 1 commit into from
May 19, 2023

Conversation

PavelVPV
Copy link
Contributor

@PavelVPV PavelVPV commented May 15, 2023 •
edited
Loading

nRF Connect SDK mesh configuration requires bigger settings
thread stack size.

Disable thread by default for nRF52832 as it doesn't fit there.

@PavelVPV PavelVPV requested a review from ludvigsj as a code owner May 15, 2023 13:09
@github-actions github-actions bot added ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels May 15, 2023
@PavelVPV PavelVPV added the bugfix Fixes a known bug label May 15, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 15, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-ble_mesh X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@alxelax alxelax self-requested a review May 15, 2023 14:21
alxelax
alxelax reviewed May 15, 2023
View reviewed changes
subsys/bluetooth/mesh/Kconfig
@@ -8,6 +8,9 @@ if BT_MESH

menu "Bluetooth mesh"

config BT_MESH_SETTINGS_WORKQ_STACK_SIZE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be changed in upstream instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will take much longer to pull the changes through upstream and will also depends on device configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Ok with this PR, but if we know the zephyr fault might happen for some configuration, shouldn't it be updated in upstream either?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check why it should be that big. I have a feeling that it is either RPL or models. If so, I'm not sure if it needs to be updated in upstream. But will decide once finish investigation.

@PavelVPV PavelVPV force-pushed the increase_settings_thread_stack_size branch from 689d33c to da0ed76 Compare May 16, 2023 11:11
@PavelVPV PavelVPV force-pushed the increase_settings_thread_stack_size branch from da0ed76 to ee5c976 Compare May 16, 2023 12:34
@PavelVPV
Copy link
Contributor Author

Decreased to 1350 to fit in light_dimmer on nRF52832.

@PavelVPV PavelVPV force-pushed the increase_settings_thread_stack_size branch from ee5c976 to e414f07 Compare May 16, 2023 13:33
@PavelVPV
Bluetooth: Mesh: Increase settings thread stack size
0fe3d7c 
nRF Connect SDK mesh configuration requires bigger settings
thread stack size.

Disable thread by default for nRF52832 as it doesn't fit there.

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
@PavelVPV PavelVPV force-pushed the increase_settings_thread_stack_size branch from e414f07 to 0fe3d7c Compare May 16, 2023 14:21
@alxelax alxelax added this to the 2.4.0 milestone May 19, 2023
@de-nordic de-nordic merged commit 48aa1f1 into nrfconnect:main May 19, 2023
12 checks passed
@PavelVPV PavelVPV deleted the increase_settings_thread_stack_size branch May 22, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludvigsj ludvigsj ludvigsj approved these changes

@alxelax alxelax alxelax approved these changes

@m-alperen-sener m-alperen-sener m-alperen-sener approved these changes

Assignees
No one assigned
Labels
ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
2.4.0
6 participants
@PavelVPV @NordicBuilder @ludvigsj @alxelax @m-alperen-sener @de-nordic