Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: Add Wi-Fi provisioning library and sample #14444

Merged
merged 2 commits into from
May 23, 2024
Merged

net: Add Wi-Fi provisioning library and sample #14444

merged 2 commits into from
May 23, 2024

Conversation

simensrostad
Copy link
Contributor

@simensrostad simensrostad commented Mar 7, 2024 •
edited

Add softap support, will be added later:

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 7, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@simensrostad simensrostad force-pushed the add_softap_support branch 2 times, most recently from e11523a to 17a5e4d Compare March 7, 2024 21:05
@simensrostad simensrostad force-pushed the add_softap_support branch 3 times, most recently from e679efb to 8d7c016 Compare March 18, 2024 14:15
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 18, 2024
@simensrostad simensrostad force-pushed the add_softap_support branch 10 times, most recently from 2083cf7 to e8dd775 Compare March 20, 2024 10:15
@NordicBuilder
Copy link
Contributor

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr ecb16c791d10fdab4a41bd3dc790610dff5e9520 6fa3e4525f7ea07ea74ba7d660d169d27c018bd3 N/A

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@simensrostad simensrostad force-pushed the add_softap_support branch 3 times, most recently from 19d46ab to faa95f5 Compare March 26, 2024 14:29
@simensrostad simensrostad changed the title samples: net: http_server: add softAP support net: lib: Add Wi-Fi provisioning library and sample Mar 26, 2024
@simensrostad simensrostad force-pushed the add_softap_support branch 2 times, most recently from 299b664 to 18bb211 Compare March 26, 2024 15:53
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed manifest labels Mar 26, 2024
divipillai
divipillai approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@divipillai divipillai left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline and more doc contents will be added in a separate PR, also covering the testing steps for the SoftAP based provision sample.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 13, 2024
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 13, 2024
@simensrostad simensrostad removed the DNM label May 13, 2024
nordicjm
nordicjm previously requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to wait for sysbuild pr to be merged and updated to use sysbuild

@simensrostad simensrostad added the CI-disable Disable CI for this PR label May 21, 2024
@simensrostad simensrostad removed the CI-disable Disable CI for this PR label May 21, 2024
@simensrostad simensrostad force-pushed the add_softap_support branch 3 times, most recently from 3c59757 to ade0bca Compare May 22, 2024 11:40
@simensrostad
Copy link
Contributor Author

Needs to wait for sysbuild pr to be merged and updated to use sysbuild

Updated sample.yaml

@simensrostad
Copy link
Contributor Author

@nordicjm Can this go in now?

@nordicjm nordicjm dismissed their stale review May 23, 2024 06:58

Block expiration

@simensrostad simensrostad force-pushed the add_softap_support branch 3 times, most recently from 8e410fa to e2c3c17 Compare May 23, 2024 10:47
@simensrostad
samples: wifi: Move and rename provisioning sample
6623d96 
Move and rename sample:
`samples: wifi: provisioning: ble`

The sample is moved under the `provisioning`
subfolder to better distinguish between it and
the upcoming the new softAP based Wi-Fi
provisioning.

Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
@simensrostad
net: Add softAP Wi-Fi provision library and sample
42b1425 
Add softAP Wi-Fi provision library and sample.

Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
@nordicjm nordicjm merged commit 819ee02 into nrfconnect:main May 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roshanrajaratnam roshanrajaratnam roshanrajaratnam left review comments

@gregersrygg gregersrygg gregersrygg approved these changes

@ioannisg ioannisg ioannisg approved these changes

@rlubos rlubos rlubos approved these changes

@balaji-nordic balaji-nordic balaji-nordic approved these changes

@divipillai divipillai divipillai approved these changes

@krish2718 krish2718 krish2718 approved these changes

@jukkar jukkar Awaiting requested review from jukkar

@wentong-li wentong-li Awaiting requested review from wentong-li wentong-li is a code owner

@bama-nordic bama-nordic Awaiting requested review from bama-nordic bama-nordic is a code owner

@krga2022 krga2022 Awaiting requested review from krga2022

@carlescufi carlescufi Awaiting requested review from carlescufi carlescufi is a code owner

@muraliThokala muraliThokala Awaiting requested review from muraliThokala

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
2.7.0