net: lib: nrf_cloud: make MQTT client ID prefix configurable #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbyheart
requested review from
plskeggs,
lemrey,
sigvartmh,
jayteemo,
tejlmand,
jtguggedal,
rlubos and
jhn-nordic
|
Recreated from fork by request from @carlescufi |
coderbyheart
changed the title
rlubos
approved these changes
Sep 22, 2020
sigvartmh
reviewed
Sep 22, 2020
sigvartmh
requested changes
Sep 22, 2020
sigvartmh
requested changes
Sep 22, 2020
|
Perfect timing for this merge request. ❤️❤️❤️ |
jtguggedal
reviewed
Sep 22, 2020
jayteemo
approved these changes
Sep 22, 2020
sigvartmh
requested changes
Sep 23, 2020
There was a problem hiding this comment.
../src/main.c: In function 'main':
../src/main.c:392:24: warning: '__builtin_snprintf' output may be truncated before the last format character [-Wformat-truncation=]
392 | snprintf(id_buf, len, "%s%s", CONFIG_NRF_CLOUD_CLIENT_ID_PREFIX,
| ^~~~~~
../src/main.c:392:29: note: format string is defined here
392 | snprintf(id_buf, len, "%s%s", CONFIG_NRF_CLOUD_CLIENT_ID_PREFIX,
| ^
In file included from /opt/tools/zephyr-sdk/arm-zephyr-eabi/arm-zephyr-eabi/sys-include/stdio.h:800,
from ../src/main.c:8:
../src/main.c:392:2: note: '__builtin_snprintf' output between 5 and 20 bytes into a destination of size 19
392 | snprintf(id_buf, len, "%s%s", CONFIG_NRF_CLOUD_CLIENT_ID_PREFIX,
| ^~~~~~~~
Still compiler warnings on aws_fota, looks like an off by 1 error.
|
@sigvartmh what are you compiling? Why do I not see those from CI? |
|
I'm using |
sigvartmh
reviewed
Sep 23, 2020
jtguggedal
approved these changes
Sep 23, 2020
jhn-nordic
approved these changes
Sep 23, 2020
tejlmand
requested changes
Sep 23, 2020
|
CI/Jenkins/FULL_CI fails with |
|
All tests green now. |
|
@tejlmand Any other feedback? The PR is pending your ACK. |
tejlmand
reviewed
Oct 1, 2020
tejlmand
approved these changes
Oct 2, 2020
The $srctree environment variable is already set to point to the Zephyr
root, so no need to do
source "$(ZEPHYR_BASE)/Kconfig.zephyr"
in samples. Just
source "Kconfig.zephyr"
works.
Signed-off-by: Markus Tacker <Markus.Tacker@NordicSemi.no>
The `nrf-` prefix is reserved for Nordic devices: https://api.nrfcloud.com/v1#operation/CreateDeviceCertificate: If you want to create a certificate for a non-Nordic device, any deviceId is sufficient that does not start with `nrf-` (we recommend using a GUID). This change allows customers to use the `asset_tracker` application with nRF Connect for Cloud with their own SIPs without modifying the source. This is especially relevant for customers that are building development kit like products, and allows them to work out of the box with the stock `asset_tracker` and nRF Connect for Cloud. Signed-off-by: Markus Tacker <Markus.Tacker@NordicSemi.no> Co-authored-by: Sigvart Hovland <Sigvart Hovland@NordicSemi.no>
hakonfam
pushed a commit
to sigvartmh/fw-nrfconnect-nrf-1
that referenced
this pull request
Oct 21, 2020
Changes introduced in nrfconnect#2349 got reverted by nrfconnect#2961 This commit re-introduces those changes. NCSDK-6750 Signed-off-by: Sigvart Hovland <sigvart.hovland@nordicsemi.no> Signed-off-by: Haakon Oeye Amundsen <haakon.amundsen@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nrf-prefix is reserved for Nordic devices: https://api.nrfcloud.com/v1#operation/CreateDeviceCertificate:This change allows customers to use the
asset_trackerapplication with nRF Connect for Cloud with their own SIPs without modifying the source. This is especially relevant for customers that are building development kit like products, and allows them to work out of the box with the stockasset_trackerand nRF Connect for Cloud.