Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: nrf9160: lwm2m_client: Add bootstrap support to the sample #2997

Merged

Conversation

rlubos
Copy link
Contributor

@rlubos rlubos commented Sep 29, 2020

Add bootstrap support to the lwm2m_client sample. Provision PSK/PSK ID received during the bootsrap procedure into the modem.

DNM until Zephyr dependencies are merged and introduced into sdk-zephyr.

@rlubos rlubos added DNM doc-required PR must not be merged without tech writer approval. labels Sep 29, 2020
@rlubos rlubos requested a review from lemrey as a code owner September 29, 2020 13:10
@rlubos
Copy link
Contributor Author

rlubos commented Sep 29, 2020

FYI @joakimtoe

@rlubos rlubos force-pushed the lwm2m/add-bootstrap-support-to-the-sample branch from b959b9f to b5fb938 Compare October 7, 2020 10:16
@rlubos rlubos requested a review from tejlmand as a code owner October 7, 2020 10:16
@rlubos rlubos added this to the 1.4.0 milestone Oct 7, 2020
int security_instance;
int security_mode;


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline

@rlubos rlubos force-pushed the lwm2m/add-bootstrap-support-to-the-sample branch 2 times, most recently from a452053 to 83ee658 Compare October 8, 2020 08:20
@tejlmand
Copy link
Contributor

tejlmand commented Oct 8, 2020

Please update SHA: d14bfb6a9e06541842ecb73e042b076ff98ed59f

@rlubos rlubos force-pushed the lwm2m/add-bootstrap-support-to-the-sample branch from 83ee658 to 7114b30 Compare October 8, 2020 09:35
@rlubos
Copy link
Contributor Author

rlubos commented Oct 8, 2020

SHA updated

@rlubos rlubos removed the DNM label Oct 8, 2020
@rlubos rlubos force-pushed the lwm2m/add-bootstrap-support-to-the-sample branch from 7114b30 to 2494d6f Compare October 8, 2020 10:06
This commits pulls latest fixes to the bootstrap procedure from
upstream.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Temporarily disable CC310 entropy driver.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Allow to store Security Credentials obtained during the bootstrap
procedure in the nRF9160 modem. This requries to shut down the lwm2m
engine and put the modem into offline state before writing the
credentials.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Add overlay file that allows to easily enable bootstrap support in the
sample.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Updated documentation of the lwm2m_client sample and added bootstrap
process description.

Signed-off-by: Uma Praseeda <uma.praseeda@nordicsemi.no>
Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
@rlubos rlubos force-pushed the lwm2m/add-bootstrap-support-to-the-sample branch from 2494d6f to 85049cb Compare October 8, 2020 10:31
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rlubos rlubos merged commit e7ce44c into nrfconnect:master Oct 8, 2020
@JusbeR
Copy link

JusbeR commented Nov 17, 2020

Do you @rlubos have any more information about the CC301 crash workaround that is merged in this PR?

I am asking because it indeed crashes for my application too after upgrading to 1.4 release and disabling it it not the best thing that one can do in production app.

@rlubos
Copy link
Contributor Author

rlubos commented Nov 17, 2020

@JusbeR unfortunately SPM entropy issue is still being investigated internally. There were some fixes in 1.4. but apparently, they weren't enough. It is suspected it might be a stack overflow in SPM, increasing the stack prevents the crash. The SPM stack is already increased on the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. manifest
Projects
None yet
5 participants