applications: serial_lte_modem: NCSIDB-258 parse large http header #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some http reply contains larger header like Set-Cookie, Report-To. If the response header is larger than receive buffer, the length of parsed http response will be over the length of receive buffer. This commit adds below changes to handle larger http response header: - increase receive buffer to 1KB - check the length of parsed response with length of receive buffer - Warning message if larger receive buffer is required The issue is reported in the below JIRA: https://projecttools.nordicsemi.no/jira/browse/NCSIDB-258 Signed-off-by: Larry Tsai <larry.tsai@nordicsemi.no>
lats1980
force-pushed
the
development/slm_httpc
branch
from
c4c93d7
to
cf2b0f3
Compare
lats1980
changed the title
rlubos
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some http reply contains larger header like Set-Cookie, Report-To.
If the response header is larger than receive buffer, the length of parsed http response
will be over the length of receive buffer.
This commit adds below changes to handle larger http response header:
The issue is reported in the below JIRA:
https://projecttools.nordicsemi.no/jira/browse/NCSIDB-258
Signed-off-by: Larry Tsai larry.tsai@nordicsemi.no