Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: asset_tracker_v2: Add support for AGPS when configuring for AWS IoT #5097

Merged
merged 2 commits into from
Aug 25, 2021
Merged

applications: asset_tracker_v2: Add support for AGPS when configuring for AWS IoT #5097

merged 2 commits into from
Aug 25, 2021

Conversation

simensrostad
Copy link
Contributor

@simensrostad simensrostad commented Jul 9, 2021 •
edited

Add support requesting and receiving AGPS data when configuring for
AWS IoT.

Closes CIA-374

@github-actions github-actions bot added CI-boot-dfu-test doc-required PR must not be merged without tech writer approval. labels Jul 9, 2021
coderbyheart
coderbyheart requested changes Jul 9, 2021
View reviewed changes
applications/asset_tracker_v2/src/cloud/cloud_codec/json_common.h Outdated Show resolved Hide resolved
applications/asset_tracker_v2/src/modules/data_module.c Outdated Show resolved Hide resolved
include/net/nrf_cloud_rest.h Outdated Show resolved Hide resolved
include/net/nrf_cloud_rest.h Outdated Show resolved Hide resolved
include/net/nrf_cloud_rest.rst Outdated Show resolved Hide resolved
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@jtguggedal jtguggedal force-pushed the agps-support-atv2-aws branch 2 times, most recently from 5b15c84 to 6bc3c2c Compare July 11, 2021 18:49
@jtguggedal
Copy link
Contributor

jtguggedal commented Jul 11, 2021 •
edited

I'm taking over this PR while @simensrostad is on vacation. Note that the PR is based on PR #4609.

Updated with a commit that does some Kconfig refactoring for nRF Cloud library. @jayteemo and @plskeggs, please have a look if those changes look okay with you. I'll soon add the same commit and one more doing similar for P-GPS in #5099.

@jtguggedal jtguggedal marked this pull request as ready for review July 11, 2021 19:06
@jtguggedal
Copy link
Contributor

Rebased on top of #4609 and addressed review comments

@jtguggedal jtguggedal removed their request for review July 13, 2021 12:14
@jtguggedal jtguggedal mentioned this pull request Jul 13, 2021
Merged
@simensrostad
Copy link
Contributor Author

@peknis This PR is now rebased on top of master. The changes you requested was a part of #4609 that was merged this morning.

@simensrostad simensrostad removed DNM doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Aug 25, 2021
coderbyheart
coderbyheart requested changes Aug 25, 2021
View reviewed changes
applications/asset_tracker_v2/src/cloud/cloud_codec/json_common.h Outdated Show resolved Hide resolved
applications/asset_tracker_v2/prj.conf Show resolved Hide resolved
applications/asset_tracker_v2/prj.conf Show resolved Hide resolved
applications/asset_tracker_v2/src/cloud/cloud_wrapper.h Outdated Show resolved Hide resolved
applications/asset_tracker_v2/src/cloud/cloud_wrapper.h Outdated Show resolved Hide resolved
applications/asset_tracker_v2/src/modules/cloud_module.c Outdated Show resolved Hide resolved
applications/asset_tracker_v2/tests/json_common/src/json_validate.h Outdated Show resolved Hide resolved
applications/asset_tracker_v2/tests/json_common/src/main.c Outdated Show resolved Hide resolved
applications/asset_tracker_v2/src/cloud/cloud_codec/json_common.c Outdated Show resolved Hide resolved
applications/asset_tracker_v2/src/modules/data_module.c Outdated Show resolved Hide resolved
@jtguggedal @simensrostad
net: lib: nrf_cloud: Reorganize Kconfig options for all APIs
803f871 
The nRF Cloud Kconfig file had become quite large, so it's now
split into separate files for each of the "sub-API"s that are offered.

At the same time, the nRF Cloud A-GPS parsing APIs are made independant
of the nRF Cloud MQTT transport being enabled.

Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Aug 25, 2021
@simensrostad
applications: asset_tracker_v2: Add support for AGPS in AWS IoT config
c577312 
Add support requesting and receiving AGPS data when configuring for
AWS IoT.

Closes CIA-374

Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
@simensrostad
Copy link
Contributor Author

@coderbyheart Review comments addressed, thanks.

@simensrostad simensrostad removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 25, 2021
@jfischer-no jfischer-no merged commit 35086db into nrfconnect:master Aug 25, 2021
@simensrostad simensrostad deleted the agps-support-atv2-aws branch September 20, 2021 09:28
@sebgus
Copy link

sebgus commented Nov 14, 2022

How do I get this to work in the Asset Tracker V2 application? I'm running the nRF connect SDK v.2.1.1 and I've set the following flags together with the overlay-aws.conf file:
CONFIG_NRF_CLOUD_AGPS=y
CONFIG_NRF_CLOUD_MQTT=y

Is there some other flag I need to set in my configuration file?
When I run towards the nRF cloud it works perfectly fine, but now I'm trying it towards my own AWS instance and the AGPS module/event is never initialized.

@simensrostad
Copy link
Contributor Author

How do I get this to work in the Asset Tracker V2 application? I'm running the nRF connect SDK v.2.1.1 and I've set the following flags together with the overlay-aws.conf file: CONFIG_NRF_CLOUD_AGPS=y CONFIG_NRF_CLOUD_MQTT=y

Is there some other flag I need to set in my configuration file? When I run towards the nRF cloud it works perfectly fine, but now I'm trying it towards my own AWS instance and the AGPS module/event is never initialized.

Hi @sebgus. Please create a support ticket on https://devzone.nordicsemi.com/ for this matter. Our support team will assist you as soon as possible.

@sebgus
Copy link

sebgus commented Nov 14, 2022

Hi @simensrostad ! Thanks for the quick reply.
I've asked that question on the nordic devzone, but the answer I got was:
"Yes, this is a feature that nrfcloud provides, and cannot be fetched with generic AWS endpoints."

Does my AWS endpoint need some special configuration?

@simensrostad
Copy link
Contributor Author

A-GPS is enabled by default for all configurations. You don't need to set

CONFIG_NRF_CLOUD_AGPS=y (enabled in `applications/asset_tracker_v2/src/modules/Kconfig.cloud_module`)
CONFIG_NRF_CLOUD_MQTT=y (This config will enable communication with nRF Cloud, but you want to configure the application for AWS)

To enable A-GPS with AWS you need to pipe A-GPS requests/responses from AWS to nRF Cloud. The nRF Asset Tracker project has documentation for this, https://nordicsemiconductor.github.io/asset-tracker-cloud-docs/v2.1.x/docs/cloud-protocol/DeviceDataAndConfiguration.html?highlight=agps#a-gps-and-p-gps-data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderbyheart coderbyheart coderbyheart approved these changes

@jayteemo jayteemo jayteemo approved these changes

@jtguggedal jtguggedal jtguggedal approved these changes

@peknis peknis peknis approved these changes

@jhn-nordic jhn-nordic Awaiting requested review from jhn-nordic

@lemrey lemrey Awaiting requested review from lemrey

@rlubos rlubos Awaiting requested review from rlubos

@plskeggs plskeggs Awaiting requested review from plskeggs

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

@umapraseeda umapraseeda Awaiting requested review from umapraseeda

@melwee01 melwee01 Awaiting requested review from melwee01

@junqingzou junqingzou Awaiting requested review from junqingzou

@lats1980 lats1980 Awaiting requested review from lats1980

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
1.7.0
8 participants
@simensrostad @NordicBuilder @jtguggedal @coderbyheart @peknis @sebgus @jayteemo @jfischer-no