Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport-ncs2.6][nrf noup] net: openthread: fix otPlatCryptoPbkdf2GenerateKey implementation #1631

Merged

Conversation

maciejbaczmanski
Copy link
Contributor

@maciejbaczmanski maciejbaczmanski commented Apr 15, 2024

OpenThread requires otPlatCryptoPbkdf2GenerateKey to be implemented by platform if PSA Crypto API is used. For ncs v2.6.0 PSA Crypto API doesn't yet fully support PBKDF2 generation. Because of that, calling otPlatCryptoPbkdf2GenerateKey results with OT_ERROR_NOT_CAPABLE error.

This commit provides a patch that allows a fallback to legacy MbedTLS implementation that follows the one provided by OpenThread.

KRKNWK-18797

@maciejbaczmanski maciejbaczmanski force-pushed the ot_pbkdf2_patch branch 2 times, most recently from cf0c7fd to 7b7b652 Compare April 15, 2024 11:34
@maciejbaczmanski maciejbaczmanski changed the title [nrf noup] net: openthread: fix otPlatCryptoPbkdf2GenerateKey implementation [backport-ncs2.6][nrf noup] net: openthread: fix otPlatCryptoPbkdf2GenerateKey implementation Apr 15, 2024
@maciejbaczmanski maciejbaczmanski marked this pull request as ready for review April 15, 2024 12:05
@maciejbaczmanski maciejbaczmanski force-pushed the ot_pbkdf2_patch branch 2 times, most recently from 922e0bf to 493cff4 Compare April 15, 2024 12:27
…mentation

OpenThread requires `otPlatCryptoPbkdf2GenerateKey` to be
implemented by platform if PSA Crypto API is used.
For ncs v2.6.0 PSA Crypto API doesn't yet fully support PBKDF2 generation.
Because of that, calling `otPlatCryptoPbkdf2GenerateKey` results with
`OT_ERROR_NOT_CAPABLE` error.

This commit provides a patch that allows a fallback to legacy MbedTLS
implementation that follows the one provided by OpenThread.

Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
Copy link
Contributor

@frkv frkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cvinayak cvinayak merged commit d5ed38a into nrfconnect:v3.5.99-ncs1-branch Apr 17, 2024
9 checks passed
@maciejbaczmanski maciejbaczmanski deleted the ot_pbkdf2_patch branch April 17, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants