Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf fromtree] boards:arm:nrf9160dk_nrf9160 add support for arduino shields #569

Closed
wants to merge 162 commits into from
Closed

[nrf fromtree] boards:arm:nrf9160dk_nrf9160 add support for arduino shields #569

wants to merge 162 commits into from

Conversation

Embla-Flatlandsmo
Copy link
Contributor

add support for shields that use arduino_i2c and
arduino_serial.

Upstream PR: zephyrproject-rtos/zephyr#36488

jtguggedal and others added 30 commits June 10, 2021 12:54
Provides an option to enable TLS session caching for an MQTT
client's secure socket.

Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
(cherry picked from commit 19c66e0)
(cherry picked from commit 7009c26)
(cherry picked from commit 23d4adb)
Add Kconfig option NET_L2_ZIGBEE to enable Zigbee L2.
It's part of porting Zigbee to IEEE 802.15.4 radio API

Signed-off-by: Maciej Fabia <maciej.fabia@nordicsemi.no>
Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
(cherry picked from commit 373acf8)
(cherry picked from commit 3ebae53)
Add a new downstream-only compatible for accessing the cryptocell from
non-secure code, and use it from the nrf9160ns.dtsi DTS include file.

This is used to keep the NCS CC310 entropy driver building following
changes to remove CONFIG_ENTROPY_NAME in favor of a zephyr,entropy
chosen node property in devicetree.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
(cherry picked from commit 4595869)
(cherry picked from commit 6f5b6f4)
The CC310 is the preferred default entropy source on platforms where
it is available. Make it so. This is a noup patch because driver
support is NCS-only.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Signed-off-by: Frank Audun Kvamtrø <frank.kvamtro@nordicsemi.no>
(cherry picked from commit 9c42b9b)
(cherry picked from commit 0f3124d)
(cherry picked from commit a8e3347)
This temphack sets `ZEPHYR_<MODULE_NAME>_KCONFIG` variable for each
Kconfig file discovered in `nrf/modules/<module>/Kconfig`.

This is a temphack to allow carefull consideration on the optimal
approach forward that will allow compliance_check.py to be used
downstream with custom module_ext_roots, and at the same time keep
current flexibility for module glue code handling intact.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
(cherry picked from commit dc7824a)
(cherry picked from commit 429476d)
-Adding cryptocell_sw as a chosen entropy source as the non-secure
 does not have access to a entropy peripheral and need to SPM (and
 later PSA APIs through the same driver
-Not upstream as driver is only downstream

ref: NCSDK-8246

Signed-off-by: Frank Audun Kvamtrø <frank.kvamtro@nordicsemi.no>
(cherry picked from commit 0c02197)
Add a binding file for nordic,nrf-cc312-sw.

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
(cherry picked from commit 59c5ac8)
This commit allows the setting of ieee802154 EUI64 address
in the non-secure build by reading the FICR or UICR registers
out of the secure zone.

Signed-off-by: Czeslaw Makarski <Czeslaw.Makarski@nordicsemi.no>
Signed-off-by: Eduardo Montoya <eduardo.montoya@nordicsemi.no>
(cherry picked from commit 0ab7df7)
(cherry picked from commit d09f04c)
Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit c676aab)
The configuration for samples with non-secure nrf5340 is not supported.

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
(cherry picked from commit 10202d4)
Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit 54f8fe7)
The current tweaks are currently applied:

- An additional check for sauce tags is added

- Since, in the code, we refer to Kconfig symbols that are defined
  in the sdk-nrf repository, the Kconfig check will not pass. Use
  KconfigBasic instead, which will not grep the code for instances
  of CONFIG_.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
(cherry picked from commit e18c99d)
Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit 3092183)
This patch is a squash containing the Jenkins-based NCS CI patches for
Zephyr thus far.

It takes over .github from the upstream maintainers for the purposes
of NCS, adds a Jenkinsfile, and adjusts the backport target.

Signed-off-by: Thomas Stilwell <Thomas.Stilwell@nordicsemi.no>
Signed-off-by: Ulrich Myhre <ulrich.solli.myhre@nordicsemi.no>
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>
Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit fdb1a78)
Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
(cherry picked from commit b6f7565)
Add some socket options and address family extensions to Zephyr
headers, which will be useful for nRF Connect SDK.

- AF_LTE family
- NPROTO_AT protocol
- NPROTO_PDN protocol, to be used in conjuction with AF_LTE
- NPROTO_DFU protocol to be used in conjuction with AF_LOCAL
- SOCK_MGMT socket type, used in conjunction with AF_LTE
- SO_BINDTODEVICE socket option
- SOL_PDN and SOL_DFU socket option levels, and associated socket
  option values: SO_PDN_CONTEXT_ID option for PDN sockets,
  SO_PDN_STATE option for PDN sockets to retrieve the state of the PDN
  connection
- SOL_DFU protocol level and socket options. This includes a
  SO_DFU_ERROR socket option for DFU socket can be used when a
  operation on a DFU socket returns -ENOEXEC, indicating that the
  modem has rejected the operation, to retrieve the reason for the
  error.
- TLS_SESSION_CACHE socket option for TLS session caching.
- SO_SNDTIMEO
- SO_SILENCE_ALL to disable/enable all replies to unexpected traffics
- SO_IP_ECHO_REPLY to disable/enable replies to IPv4 ICMPs
- SO_IPV6_ECHO_REPLY to disable/enable replies to IPv6 ICMPs
- MSG_TRUNC
- MSG_WAITALL socket flag required to support the corresponding NRF
  counterpart flag, for translation within the offloading interface.

Signed-off-by: Håkon Alseth <haal@nordicsemi.no>
Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Signed-off-by: Glenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>
Signed-off-by: Christopher Métrailler <christopher.metrailler@nordicsemi.no>
Signed-off-by: Emanuele Di Santo <emdi@nordicsemi.no>
Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
Signed-off-by: Jan Tore Guggedal <jantore.guggedal@nordicsemi.no>
Signed-off-by: Tommi Mammela <tommi.mammela@nordicsemi.no>
Signed-off-by: Petri Honkala <petri.honkala@nordicsemi.no>
Signed-off-by: Mirko Covizzi <mirko.covizzi@nordicsemi.no>
Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit 611475c)
Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
(cherry picked from commit 745826d)
Partition Manager (PM) is a component of the nRF Connect SDK (NCS)
which uses yaml files to resolve flash partition placement with a
holistic view of the entire device, including each firmware image
present on the flash device, and various subsystems, such as settings
and NFFS.

When this NCS extension is used, various source files which would use
partition information from devicetree in "vanilla" zephyr instead use
defines generated by PM instead.

This commit removes support for HEX_FILES_TO_MERGE, as it conflicts
with PM.

The settings subsystem pm.yml defines a partition 'settings_storage'.
The nffs subsystem pm.yml defines 'nffs_storage'.

Leverage label translation to avoid patching partition names.

Refer to the NCS documentation page for this feature for more details.

This is a long-running out of tree patch which has been worked on by
several people. The following sign-offs are in alphabetical order by
first name.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Signed-off-by: Ole Sæther <ole.saether@nordicsemi.no>
Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
Signed-off-by: Sigvart Hovland <sigvart.hovland@nordicsemi.no>
Signed-off-by: Thomas Stenersen <thomas.stenersen@nordicsemi.no>
Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
(cherry picked from commit 71911aa)
Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
(cherry picked from commit c606417)
Enable dynamic power control in hci_pwr_ctrl sample for
platforms using hci_rpmsg as controller

Signed-off-by: Azizah Ibrahim <azizah.ibrahim@nordicsemi.no>
(cherry picked from commit 6a1d340)
Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
(cherry picked from commit e1de791)
SPM is the default for NCS. Revert this change to ensure
that SPM is set for NCS.

Ref: NCSDK-9282
Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
(cherry picked from commit b3de9b0)
The CONFIG_NRF_RTC_TIMER_USER_CHAN_COUNT must be set for 802154_rpmsg
sample to properly allocate timers for nRF-802154 driver.

Upstream PR: zephyrproject-rtos/zephyr#34729

Signed-off-by: Rafał Kuźnia <rafal.kuznia@nordicsemi.no>
(cherry picked from commit aed01ec)
.known-issues have been deleted upstream, and can be removed in
downstream as well, which previously had manual changes.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
(cherry picked from commit e711e7b)
Add AI_PDNSERV flag, to to specify the ID
of the PDN to route DNS queries through.

Used since libmodem v1.1.0.

Signed-off-by: Emanuele Di Santo <emdi@nordicsemi.no>
(cherry picked from commit f725ac7)
-In line with configuration for TF-M builds

Signed-off-by: Frank Audun Kvamtrø <frank.kvamtro@nordicsemi.no>
Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
(cherry picked from commit c5feda0)
…phyr

Zephyr has introduced secure random generator API after the TLS sockets
were implemented. Use this new API in TLS sockets implementation,
instead of implementing secure RNG with mbedTLS in the module itself.
This facilitates integration of the HW RNG accelerators with the TLS
sockets module.

Signed-off-by: Frank Audun Kvamtrø <frank.kvamtro@nordicsemi.no>
Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
(cherry picked from commit a409bc7)
... symbol selection"

This reverts commit 0924cb5.

Ref: NCSDK-7591

Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
(cherry picked from commit 0332aac)
Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit 13be9e0)
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit b88e9b1)
The Kconfig reference is being turned into a separate shared
documentation set, which needs three nRF-specific Zephyr tweaks:

 1. Do not build the Kconfig docs as part of the Zephyr documentation

 2. Do not link the index page of the Kconfig docs in the Zephyr
    documentation

 3. Pass some extra variables with output paths through to sphinx-build,
    so that they can be referenced in nrf/doc/zephyr/conf.py. They're
    used for the Intersphinx linking.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
(cherry picked from commit 7bedae6)
Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
(cherry picked from commit 64365f8)
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit 4a156b9)
So the out-of-tree board can access Zephyr source files.

Ref: NCSDK-8303

Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
(cherry picked from sdk-trusted-firmware-m commit
d372deeb1c96f64de2713d17b7d8fcd982da5e3a)
Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
(cherry picked from commit c11181d)
Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
(cherry picked from commit 4cd290a)
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit 408a4c0)
…rk runs

The original state management solution involved separate locks for a
work queue and each work item.  To avoid inter-lock dependencies a
window was left between the point where the work item was removed from
the queue (protected by queue lock) and the point where the work item
state was updated to mark the work item running.

This introduced a bug: If a cancellation was issued during this window
it would succeed, and the work item would appear to be idle even
though in fact the work queue thread was about to run it.

Since there is now only one lock, move the work item state updates
into the mutex regions associated with dequeuing the work item and
clearing the work queue busy flag.

Note that removing the window between queue and work mutex regions
eliminates the potential of having a dequeued work item be cancelled
before its QUEUED flag is cleared, simplifying the work item state
update.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
(cherry picked from commit 656c095)
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit 88a5765)
Do not assert initialization priority when building
with CONFIG_TRUSTED_EXECUTION_SECURE=y.
Regulators are not enabled so should not assert
initialization chain priorities.

Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>
(cherry picked from commit 9a3b6bb)
C++ compiliation may generate warning if some fields are not
explicitly initialized. Added explicit initialization to 0.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit 8de6fe4)
…ture fields

C++ compiliation may generate warning if all fields are not
explicitly initialized. Added explicit initialization to 0.

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit 4d0e578)
Picky C++ compilation reported warnings that input arguments
are not used. Adding missing ARG_UNUSED().

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit 0a399df)
Change updates pm_control function to make it compatible with new
API.

upstream PR: zephyrproject-rtos/zephyr#35434

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
(cherry picked from commit 3851a14)
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit 7a2d69d)
…ment

When application calls TCP connect(), the call is blocked
by a semaphore which is then released when the connection
is established. Unfortunately the semaphore release was done
before the connection was marked as established. Depending
on the configuration options set, it is possible that after
the semaphore release, the thread that is waiting on connect()
is run immediately. Because of this, the connection bookeeping
still thought that the connection was not established even if
it was. A simple solution is to release the semaphore after
the connection is marked as established.

Fixes #35390

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
(cherry picked from commit 03e1872)
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit 8867251)
tejlmand and others added 11 commits June 16, 2021 17:40
Fixes: NCSDK-10008

Set number of parallel jobs for TF-M build to 1.
In some circumstances it has been experienced that building TF-M with
multiple parallel jobs then `permission denied` may occur.
Root cause on Windows has not been identified but current suspicion
is around folder / file lock mechanism. To ensure correct behaviour
in all cases, limit number of parallel jobs to 1.

This issue is especially experienced when building TF-M through SES-NE.

This fix should be reverted when the root cause has been identified and
fixed.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
The CMake variable `TFM_ISOLATION_LEVEL_ARG` was not properly set when
application configures higher isolation level. This led to isolation
level always being to set 1.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@linaro.org>
Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
This is a follow-up to commit 60d9988.

Add a third option for the HFXO capacitance that keeps the default
value of the XOSC32MCAPS register untouched. The message in the above
commit incorrectly claimed that external load capacitors for HFXO
(the reset value of the XOSC32MCAPS register) was the configuration
in effect before. In fact, the register value was modified during
the device trimming in the SystemInit() function to use the internal
capacitors, and that is the configuration required for proper RADIO
operation on nRF5340 DK, for instance.

Upstream PR: zephyrproject-rtos/zephyr#36320

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
... pairing procedure

Moving the key check after checking that no pairing or encryption
procedure is started fixes a race condition that is seen in some PTS
tests:

GATT/CL/GAR/BI-04-C
GATT/CL/GAR/BI-16-C
GATT/CL/GAR/BI-21-C
GATT/CL/GAW/BI-05-C
GATT/CL/GAW/BI-12-C

Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
In case of non-recoverable errors (e.g. the connection breaks while
transmitting), the l2cap_chan_tx_process deques the net_buf but does
not unreference it. As this is inside a work queue thread, the sending
thread gets no information on this error, relying on the tx_process to
ultimately free the buffer.

Upstream PR: zephyrproject-rtos/zephyr#36031

Signed-off-by: Patrick Rathje <git@patrickrathje.de>
... response data

Check the length field of the scan response data.

Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
(cherry picked from commit 95e359d)
Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
... peripheral

Fix to avoid an assertion when processing an acknowledgment
in the first connection event in peripheral role.

Ensure that empty flag reflects the state of the Tx queue,
as a peripheral the first connection event has no prior PDU
transmitted, an incorrect acknowledgment by peer should
not dequeue a PDU that has not been transmitted on air.

Relates to assert added in commit 2bfaadf ("Bluetooth:
controller: Add Tx fragmentation assertion").

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
(cherry picked from commit 79f6a63)
Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
This commit fixed buggy fall-throughs introduced with
recent changes to nRF5 shim layer.

Upstream PR: zephyrproject-rtos/zephyr#36252

Signed-off-by: Rafał Kuźnia <rafal.kuznia@nordicsemi.no>
…module

A new configuration is available in TF-M, for disabling RNG
independent from key derivation. Introduce a corresponding
Kconfig option to control the RNG API enabling/disabling from
Zephyr.

Ref: NCSDK-10031
Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Configured UART/UARTE input pins to have pullups. Otherwise when
uart is disconnected pins are floating and generate receiver
errors.

Upstream PR: zephyrproject-rtos/zephyr#36366

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
`OPENTHREAD_SHELL` does no longer dependend on
`OPENTHREAD_COPROCESSOR` being disabled.

Upstream PR: zephyrproject-rtos/zephyr#36401

Signed-off-by: Eduardo Montoya <eduardo.montoya@nordicsemi.no>
… shields

add support for shields that use arduino_i2c and
arduino_serial.

Upstream PR: zephyrproject-rtos/zephyr#36488

Signed-off-by: Embla Flatlandsmo <embla.flatlandsmo@nordicsemi.no>
Copy link
Contributor

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must change commit sauce tag to "from tree"

@Embla-Flatlandsmo Embla-Flatlandsmo changed the title [nrf fromlist] boards: arm: nrf9160dk_nrf9160 add support for arduino shields [nrf fromtree] boards: arm: nrf9160dk_nrf9160 add support for arduino shields Jun 25, 2021
@Embla-Flatlandsmo Embla-Flatlandsmo changed the title [nrf fromtree] boards: arm: nrf9160dk_nrf9160 add support for arduino shields [nrf fromtree] boards:arm:nrf9160dk_nrf9160 add support for arduino shields Jul 6, 2021
@carlescufi
Copy link
Contributor

@Embla-Flatlandsmo is this still necessary? Otherwise please close it.

@Embla-Flatlandsmo
Copy link
Contributor Author

@carlescufi 1: I'm getting the compliance check fail on: UC5 Title exceeds max length (77>75): "[nrf fromlist] boards: arm: nrf9160dk_nrf9160 add support for arduino shields"
How can I change the PR title to make it comply properly? I thought it needed the exact same name as the upstream PR but prepended with the sauce tag.

@carlescufi
Copy link
Contributor

This is no longer necessary, the code is already part of the tree.

@carlescufi carlescufi closed this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet