Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for compatibility with latest twitter-text gem #92

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

andreas12345
Copy link
Contributor

Replace Twitter::Autolink by Twitter::TwitterText::Autolink

@Nakilon
Copy link

Nakilon commented Apr 26, 2018

The patch should probably include the twitter's gem version stated in .gemspec

@bartkamphorst
Copy link
Contributor

@Nakilon Can you expand on what is needed for this PR to be merged? Would you need an explicit version number specified in the gemspec, like s.add_dependency 'twitter-text', '>= 2.0' or something?

Gollum has fixed twitter-text to 1.14.7 at the moment, but ideally we would able to use the latest version of that gem.

@Nakilon
Copy link

Nakilon commented Nov 30, 2018

@bartkamphorst yeah, the "update for compatibility" does not really tell the library user which version is compatible and which is not. It would be nice to have the version specified as 'twitter-text', ~> ...

@bartkamphorst
Copy link
Contributor

Thanks @Nakilon . The relevant commit is FalconSocial/twitter-text@e304fc6, where the top-level namespace was changed and the version was bumped to v.2.1.0.

@andreas12345 Could you modify your PR by changing line 25 in wikicloth.gemspec to s.add_dependency 'twitter-text', '>= 2.1'?

@dometto
Copy link
Contributor

dometto commented May 3, 2019

@nricciar would you merge a similar PR if someone reopens it with the changes suggested by @bartkamphorst and @Nakilon

@bartkamphorst
Copy link
Contributor

Ping @andreas12345 .

…r::Autolink by Twitter::TwitterText::Autolink
@andreas12345
Copy link
Contributor Author

Done!

@andreas12345 andreas12345 reopened this Sep 6, 2019
@dometto
Copy link
Contributor

dometto commented Sep 10, 2019

Ping @nricciar

@nricciar nricciar merged commit 54ad028 into nricciar:master Sep 10, 2019
@dometto
Copy link
Contributor

dometto commented Sep 10, 2019

Great, thanks so much @nricciar! 🎆 Any chance you could cut a quick new release of the gem? Last version on rubygems is from 2015, I'm sure many people would appreciate a new version with the updates that have been made over the past years!

@bartkamphorst
Copy link
Contributor

@nricciar Seconding the request for a new wikicloth release. Would be much appreciated!

@Nakilon
Copy link

Nakilon commented Sep 19, 2019

Just a reminder: you can specify the Github repo+branch in your Gemfile when the published gem is outdated.

@vinc vinc mentioned this pull request Jan 3, 2020
@dometto
Copy link
Contributor

dometto commented Jan 8, 2023

Just a reminder: you can specify the Github repo+branch in your Gemfile when the published gem is outdated.

Unfortunately this is not a solution for gems, since gem dependencies must be declared in a .gemspec, not in a Gemfile. Is there anyone with the ability to release a new gem version of wikicloth?

@Nakilon
Copy link

Nakilon commented Jan 8, 2023

not a solution for gems

While this is true, you can temporary provide a guide for your gem users that when they want to use yours they have to add two lines to Gemfile, not one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants