-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for compatibility with latest twitter-text gem #92
Conversation
The patch should probably include the twitter's gem version stated in .gemspec |
@Nakilon Can you expand on what is needed for this PR to be merged? Would you need an explicit version number specified in the gemspec, like Gollum has fixed |
@bartkamphorst yeah, the "update for compatibility" does not really tell the library user which version is compatible and which is not. It would be nice to have the version specified as |
Thanks @Nakilon . The relevant commit is FalconSocial/twitter-text@e304fc6, where the top-level namespace was changed and the version was bumped to @andreas12345 Could you modify your PR by changing line 25 in wikicloth.gemspec to |
@nricciar would you merge a similar PR if someone reopens it with the changes suggested by @bartkamphorst and @Nakilon |
Ping @andreas12345 . |
…r::Autolink by Twitter::TwitterText::Autolink
Done! |
Ping @nricciar |
Great, thanks so much @nricciar! 🎆 Any chance you could cut a quick new release of the gem? Last version on rubygems is from 2015, I'm sure many people would appreciate a new version with the updates that have been made over the past years! |
@nricciar Seconding the request for a new wikicloth release. Would be much appreciated! |
Just a reminder: you can specify the Github repo+branch in your Gemfile when the published gem is outdated. |
Unfortunately this is not a solution for gems, since gem dependencies must be declared in a |
While this is true, you can temporary provide a guide for your gem users that when they want to use yours they have to add two lines to Gemfile, not one. |
Replace Twitter::Autolink by Twitter::TwitterText::Autolink