Improve package.json search performance #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously yarn-recursive would exhaustively search all subdirectories, including node_modules. Unwanted subdirectories were then filtered out after the fact. This caused an unnecessary delay on startup, especially for very large projects with lots of dependencies. After this change, yarn-recursive skips over node_modules altogether - it never enters a node_modules directory or reads its contents.
|
On my fairly small project this reduces build times by six seconds. The saving is likely to be on the order of minutes for large projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance by skipping over
node_modulesdirectories.Before this change, yarn-recursive would exhaustively search all subdirectories, including
node_modules. Unwanted subdirectories were then filtered out after the fact. This caused an unnecessary delay on startup, especially for very large projects with lots of dependencies.After this change, yarn-recursive skips over
node_modulesaltogether - it never enters anode_modulesdirectory or reads its contents.