Skip to content

Commit

Permalink
Commenting out all AI_CANONNAME tests for now. Much further research …
Browse files Browse the repository at this point in the history
…needed; may never be cross-platform testable.

git-svn-id: https://jython.svn.sourceforge.net/svnroot/jython/trunk/jython@6520 79b11f02-f210-0410-99aa-fb189b3d1ac4
  • Loading branch information
amak committed Jul 7, 2009
1 parent 68bd396 commit f6dd746
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Lib/test/test_socket.py
Expand Up @@ -1453,12 +1453,13 @@ def testAI_PASSIVE(self):
(socket.AI_PASSIVE, "localhost", "", IPV4_LOOPBACK),
(socket.AI_PASSIVE, local_hostname, "", local_ip_address),
# Now passive flag AND canonname flag
(socket.AI_PASSIVE|socket.AI_CANONNAME, None, "127.0.0.1", "127.0.0.1"),
(socket.AI_PASSIVE|socket.AI_CANONNAME, "", local_hostname, local_ip_address),
# Commenting out all AI_CANONNAME tests, results too dependent on system config
#(socket.AI_PASSIVE|socket.AI_CANONNAME, None, "127.0.0.1", "127.0.0.1"),
#(socket.AI_PASSIVE|socket.AI_CANONNAME, "", local_hostname, local_ip_address),
# The following gives varying results across platforms and configurations: commenting out for now.
# Javadoc: http://java.sun.com/j2se/1.5.0/docs/api/java/net/InetAddress.html#getCanonicalHostName()
#(socket.AI_PASSIVE|socket.AI_CANONNAME, "localhost", local_hostname, IPV4_LOOPBACK),
(socket.AI_PASSIVE|socket.AI_CANONNAME, local_hostname, local_hostname, local_ip_address),
#(socket.AI_PASSIVE|socket.AI_CANONNAME, local_hostname, local_hostname, local_ip_address),
]:
addrinfos = socket.getaddrinfo(host_param, 0, socket.AF_INET, socket.SOCK_STREAM, 0, flags)
for family, socktype, proto, canonname, sockaddr in addrinfos:
Expand Down

0 comments on commit f6dd746

Please sign in to comment.