minimal fix for segfault when redis goes away - causes php exception #22

Open
wants to merge 1 commit into
from

Projects

None yet

3 participants

@cybafelo

Here's my two cents on the segfault problem mentioned by @theintz

This is a slightly different solution - it raises an exception in php when redis server goes away during redisGetReply, creates an "error" reply object which gets freed almost immediately.

But of course i did not check other places where the reply* pointer should probably be initialized to null

@nrk
Owner
nrk commented Mar 25, 2014

Hi @cybafelo,

I just merged the fix proposed by @theintz to avoid the segfaults. As for your proposal, as far as I understand I guess it could be covered and handled by #19, or am I missing something?

@theintz
Contributor
theintz commented Mar 25, 2014

This approach fixes the problem as well, but introduces Exceptions, which we decided not to use in #18.

@cybafelo

hey you're right it is covered by 19, cool thank you for taking the time to sort it out :)

Sent from my iPad

On 25.03.2014, at 12:22, Daniele Alessandri notifications@github.com wrote:

Hi @cybafelo,

I just merged the fix proposed by @theinz to avoid the segfaults. As for your proposal, as far as I understand I guess it could be covered and handled by #19, or am I missing something?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment