Phpiredis + predis 1.0 performance issue

[ad34]

Not sure if the issue is in predis or phpiredis itself, but I ve got a performance issue with predis and phpiredis and I don't reproduce the issue without the phpiredis connector

script to reproduce:

array('tcp' => 'Predis\Connection\PhpiredisStreamConnection') ); $predis = new Predis\Client($parameters, $options); $t = microtime(true); $c = $predis->get('communities'); echo "time to fetch communities : ".(microtime(true)-$t); ?>

some call , like 1 / 3 or 1/4 takes 60 seconds

time to fetch communities : 60.002037643

if I remove the 'connections' option the script runs fast all time

time to fetch communities : 0.0055761337280273

[nrk]

Did you try disabling persistent connections and see if the issue is still present?

[ad34]

Yes, the issue is still present without persistant connexion

[nrk]

Try replacing this line in lib/Predis/Connection/PhpiredisStreamConnection.php with the following one:

$buffer = stream_socket_recvfrom($socket, 4096);

And see if anything changes.

[ad34]

Looks like it fixes the issue , nice !

[nrk]

Actually I'm surprised to see I used fread there to begin with due to how the streaming parser of phpiredis works, anyway I'll take some time to test the change before pushing it into the repository. In the meanwhile you can stick with it and eventually leave a new comment if you find it unstable.

Thanks!