Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests, list of allowed commands have changed (redis 3.0.6) #296

Merged
merged 1 commit into from
May 8, 2016

Conversation

remicollet
Copy link
Contributor

Detected in Fedora QA, broken since redis 3.0.6

See https://apps.fedoraproject.org/koschei/package/php-nrk-Predis

 There were 2 failures:
 1) Predis\Command\PubSubSubscribeByPatternTest::testCannotSendOtherCommandsAfterPsubscribe
 Failed asserting that exception message 'ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context' contains 'ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / QUIT allowed in this context'.
 2) Predis\Command\PubSubSubscribeTest::testCannotSendOtherCommandsAfterSubscribe
 Failed asserting that exception message 'ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context' contains 'ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / QUIT allowed in this context'.
 FAILURES!

@remicollet
Copy link
Contributor Author

In build history (https://apps.fedoraproject.org/koschei/package/php-nrk-Predis) you will notice build failure since redis 3.0.6 (2015-12-19 02:23:40), and back to normal since this patch is applied (2015-12-28 09:44:30)

@nrk nrk merged commit f378faa into predis:v1.0 May 8, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants