Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to set auto start of tab cycle via config #26

Merged
merged 2 commits into from
May 8, 2018
Merged

allow to set auto start of tab cycle via config #26

merged 2 commits into from
May 8, 2018

Conversation

tolu
Copy link
Contributor

@tolu tolu commented May 7, 2018

To support the case when you have the dashboard displayed via something that lacks input devices it would be beneficial to be able to start the tab cycle via configuration instead of click.

Solution

Add config tabCycleAutoStart: boolean to config/appconfig.js and corresponding logic to src/controller.js

@tolu tolu self-assigned this May 7, 2018
@tolu tolu requested a review from oyvindholmstad May 7, 2018 09:51
@tolu tolu merged commit 4e58120 into master May 8, 2018
@tolu tolu deleted the play-cycle-via-config branch May 8, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindholmstad oyvindholmstad oyvindholmstad approved these changes

Assignees

@tolu tolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tolu @oyvindholmstad