Socket-child can be left orphaned on parent crash

[Julusian]

• I'm submitting a ...
  [*] bug report

• Summary
  I appear to have had another possible occurrence of Socket-child can be left orphaned on parent crash #30. I noticed my cpu fan running pretty high and turns out I have 2 atem-connections still open and maxing out a core each.

• Other information
  Running v0.8.0
  I had playout-gateway crash a couple of times on me earlier on today, this could have been caused by that, but the stack trace is unrelated

I found I could attach a debugger to the process (https://hackernoon.com/debugging-node-without-restarting-processes-bd5d5c98f200), and the console is being flooded with:

warning.js:18 (node:8448) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'emit' of undefined
    at log (/home/julus/Projects/tv-automation-playout-gateway/node_modules/atem-connection/dist/lib/atemSocketChild.js:80:14)
    at Object.onFailedAttempt (/home/julus/Projects/tv-automation-playout-gateway/node_modules/atem-connection/dist/lib/atemUtil.js:74:21)
    at Promise.resolve.then.then.error (/home/julus/Projects/tv-automation-playout-gateway/node_modules/p-retry/index.js:44:14)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

warning.js:18 (node:8448) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 30132)

And a cpu profile: CPU-20181203T211452.zip
I cant think of anything else I can look at to get more info

[Abrahamic-God]

I feel pretty silly about not putting uncaughtException and unhandledRejection handlers on the child process. It should absolutely abort and exit with an error code when either of those happen.

[Julusian]

I havent seen this in a while, so I assume those fixes worked