Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket-child can be left orphaned on parent crash #68

Closed
Julusian opened this issue Nov 22, 2019 · 1 comment
Closed

Socket-child can be left orphaned on parent crash #68

Julusian opened this issue Nov 22, 2019 · 1 comment

Comments

@Julusian
Copy link
Member

Companion crashed a bunch of times at startup due to mismatch in natives api version.
I think a bunch of these aren't from crashes, but are from running via nodemon. Every time it restarts another child gets added

image

@Julusian
Copy link
Member Author

The child has been rewritten to be a ThreadedClass which should be better at avoiding this, especially as it now runs as a worker thread when possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant