-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rework CacheForPlayout as structured objects SOFIE-2663 SOFIE-2513 #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release51 #1035 +/- ##
=============================================
+ Coverage 58.05% 58.20% +0.15%
=============================================
Files 485 507 +22
Lines 78987 81414 +2427
Branches 4130 4279 +149
=============================================
+ Hits 45855 47391 +1536
- Misses 33077 33965 +888
- Partials 55 58 +3
☔ View full report in Codecov by Sentry. |
f4e7999
to
bace121
Compare
f06cb4d
to
023756c
Compare
023756c
to
2b032f3
Compare
431408e
to
aeb001a
Compare
fc0470f
to
cbc551a
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code improvement
The current
CacheForPlayout
is based around providing a mongo-like interface. This made it easy to introduce many releases back when we first added the caches.This reworks the cache to be a structure of objects, with various methods exposed for mutation.
This collects the various mutations that the code can do during playout into a set of classes. This will make it easier to test the code, and should aid developers in understanding the code.
This is inspired by the rewrite TV2DK are doing, but keeping the scope a lot smaller and more incremental.
This PR does not aim to give a perfect implementation of anything, but to be a bulky refactor which gets the general structure in place. It is intended that other portions of the code which call this model to be refactored/tidied up later on.
In the future I expect:
Status