-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sourcelayer "studio screen" (SOFIE-3132) #1189
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release51 #1189 +/- ##
=============================================
- Coverage 58.10% 58.10% -0.01%
=============================================
Files 483 483
Lines 79442 79451 +9
Branches 4000 3548 -452
=============================================
+ Hits 46162 46166 +4
- Misses 33255 33280 +25
+ Partials 25 5 -20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the new type be included in any of the following locations too?
const supportedLayers = new Set([ switch (props.sourceLayer.type) { export const pieceIconSupportedLayers = new Set([ (piece.sourceLayer?.type === SourceLayerType.GRAPHICS || piece.sourceLayer?.type === SourceLayerType.LOWER_THIRD) &&
I'm honestly not sure if it should, I don't know what the PieceIcons
stuff is for or where they are used. The PieceMultistepChevron
one will be wanted though.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a:
Feature
Current Behavior
Graphics that are intended for backscreens in the studio have been put on the GRAPHICS layer (which is used for fullscreen gfx). However there is a need to distinguish the back screen graphcs from lower-thirds and fullscreen gfx.
New Behavior
A new SourceLayer "STUDIO_SCREEN" has been added, intended to be used for content targeting studio screens.
Testing
Affected areas
This PR affects the GUI / display of Pieces.
Time Frame
No rush, but we're aiming at merging this into R51 within a week.
Other Information
Status