fix: dashboard panel scale affecting position #655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix (UI)
What is the current behavior? (You can also link to an open issue here)
Setting a Scale other than 1 on some dashboard panels (NextInfoPanel and PieceCountdownPanel) affects their position change. Cause: changing fontSize on an element positioned using
em
.What is the new behavior (if this is a feature change)?
Positioning on these panels is fixed to work exactly as other panels.
Other information:
The additional variable (
--dashboard-panel-scale
) is not used by these panels, but used by TV 2's keyboard map. Can it stay there?Status