Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard panel scale affecting position #655

Merged
merged 2 commits into from May 16, 2022

Conversation

ianshade
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix (UI)

  • What is the current behavior? (You can also link to an open issue here)
    Setting a Scale other than 1 on some dashboard panels (NextInfoPanel and PieceCountdownPanel) affects their position change. Cause: changing fontSize on an element positioned using em.

  • What is the new behavior (if this is a feature change)?
    Positioning on these panels is fixed to work exactly as other panels.

  • Other information:
    The additional variable (--dashboard-panel-scale) is not used by these panels, but used by TV 2's keyboard map. Can it stay there?

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #655 (aa2b73d) into release39 (5738a17) will not change coverage.
The diff coverage is n/a.

❗ Current head aa2b73d differs from pull request most recent head ae09803. Consider uploading reports for the commit ae09803 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           release39     #655   +/-   ##
==========================================
  Coverage      67.87%   67.87%           
==========================================
  Files            275      275           
  Lines          19160    19160           
  Branches        4316     4316           
==========================================
  Hits           13005    13005           
  Misses          6078     6078           
  Partials          77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5738a17...ae09803. Read the comment docs.

@Julusian Julusian added Contribution from TV 2 Danmark Contributions sponsored by TV 2 Danmark (tv2.dk) 🐛🔨 bugfix This is a fix for an issue labels Jan 14, 2022
@Julusian Julusian requested a review from jstarpl January 14, 2022 11:41
meteor/client/ui/Shelf/NextInfoPanel.tsx Outdated Show resolved Hide resolved
meteor/client/ui/Shelf/PieceCountdownPanel.tsx Outdated Show resolved Hide resolved
changing font size broke positioning based on em;
fix it by using a CSS var instead, and let panels use it on child elements
@ianshade ianshade force-pushed the contribute/fixDashboardScale branch from 9a10b42 to 0b14da8 Compare May 13, 2022 10:51
@ianshade ianshade changed the base branch from release39 to release43 May 13, 2022 10:51
@ianshade ianshade requested a review from jstarpl May 13, 2022 10:52
@jstarpl jstarpl merged commit 9e762ec into nrkno:release43 May 16, 2022
@jstarpl jstarpl deleted the contribute/fixDashboardScale branch May 16, 2022 16:16
@Julusian Julusian mentioned this pull request May 18, 2022
5 tasks
@Julusian Julusian mentioned this pull request Jul 5, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛🔨 bugfix This is a fix for an issue Contribution from TV 2 Danmark Contributions sponsored by TV 2 Danmark (tv2.dk)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants