Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor update to 2.5.3 #664

Merged
merged 9 commits into from Jan 27, 2022
Merged

Meteor update to 2.5.3 #664

merged 9 commits into from Jan 27, 2022

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Jan 18, 2022

This PR update Meteor to 2.5.3. It also update the Meteor-packages to their latest versions.

Note to the reviewer: Please test this on your local system before approving.

@nytamin nytamin changed the title Fix/meteor update Meteor update to 2.5.3 Jan 18, 2022
@nytamin nytamin requested a review from a team January 18, 2022 11:26
@github-actions
Copy link

⚡ Published prerelease version server-core-integration@1.39.0-nightly-release40-20220118-121857-42d8bea.0 to NPM

@github-actions
Copy link

⚡ Published prerelease version blueprints-integration@1.39.0-nightly-release40-20220118-121857-42d8bea.0 to NPM

Copy link
Member

@jstarpl jstarpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working OK. The only problems I've run into seemed to be R40 related, and not related to the Meteor update.

@Julusian
Copy link
Member

@nytamin Ive bumped meteor to 2.5.5.
I also noticed that you missed updating the docker images, and some of the build process.

It would be good to give this a test in xpro before merging too (once r40 is working there)

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #664 (5cc1f12) into release40 (99a3089) will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release40     #664      +/-   ##
=============================================
+ Coverage      63.87%   63.89%   +0.02%     
=============================================
  Files            295      295              
  Lines          18596    18590       -6     
  Branches        4406     4403       -3     
=============================================
  Hits           11878    11878              
+ Misses          6375     6369       -6     
  Partials         343      343              
Impacted Files Coverage Δ
meteor/server/api/profiler.ts 50.00% <20.00%> (-16.67%) ⬇️
meteor/server/coreSystem.ts 84.61% <100.00%> (+3.88%) ⬆️
meteor/lib/lib.ts 69.44% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a3089...5cc1f12. Read the comment docs.

Copy link
Member

@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had no noticable issues for some basic ingest and playout on macos on m1

@nytamin
Copy link
Contributor Author

nytamin commented Jan 27, 2022

Tests in xpro (our testing environment) looks good!

@nytamin nytamin merged commit 343ddd4 into release40 Jan 27, 2022
@nytamin nytamin deleted the fix/meteor-update branch January 27, 2022 11:20
@Julusian Julusian mentioned this pull request Feb 9, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants