Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ask confirmation before restarting playout gateway #666

Merged
merged 1 commit into from Jan 24, 2022
Merged

fix: ask confirmation before restarting playout gateway #666

merged 1 commit into from Jan 24, 2022

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Jan 20, 2022 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

When restarting a CasparCG Server from the Rundown View, the user is asked for confirmation before doing the operation. No such prompt is shown when restarting the Playout Gateway, creating an uneaven UX.

  • What is the new behavior (if this is a feature change)?

A prompt is shown before restarting the Playout Gateway.

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@jstarpl jstarpl added the 🐛🔨 bugfix This is a fix for an issue label Jan 20, 2022
@jstarpl jstarpl merged commit ca9dba1 into release40 Jan 24, 2022
@jstarpl jstarpl deleted the fix/confirm-restart-pdevice branch January 24, 2022 09:06
@Julusian Julusian mentioned this pull request Feb 9, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gundelsby gundelsby gundelsby approved these changes

Assignees
No one assigned
Labels
🐛🔨 bugfix This is a fix for an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jstarpl @gundelsby