Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: no default tabs when using Shelf Layout #684

Merged
merged 3 commits into from Feb 17, 2022
Merged

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Feb 15, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature change - this is a breaking change for anyone using Custom Shelf Layouts.

  • What is the current behavior? (You can also link to an open issue here)

When custom Shelf Layout is used, AdLibs and Global AdLib tabs are still shown.

  • What is the new behavior (if this is a feature change)?

When a custom Shelf Layout is used, AdLibs and Global AdLibs tabs are not shown.

  • Other information:

This PR refactors a lot of the AdLib Shelf List code to be more modular and use React Hooks whenever possible. Also, since these custom Tabs will now need to sometimes function as main AdLib and Global AdLib tabs, the rendering performance of this component has been increased through use of memoization. Some unused code was removed also. Also, regular Global AdLib panel has been refactored so that it's just an AdLib panel with a hard-coded filter. This should DRY the code out some.

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@jstarpl jstarpl changed the base branch from master to release41 February 15, 2022 14:36
…. Memoize as much as possible for better performance.
@jstarpl jstarpl marked this pull request as ready for review February 16, 2022 09:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #684 (6a62e9d) into release41 (e311477) will not change coverage.
The diff coverage is n/a.

❗ Current head 6a62e9d differs from pull request most recent head 42b6a9d. Consider uploading reports for the commit 42b6a9d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           release41     #684   +/-   ##
==========================================
  Coverage      69.46%   69.46%           
==========================================
  Files            299      299           
  Lines          33347    33347           
  Branches        4664     4664           
==========================================
  Hits           23164    23164           
  Misses          9735     9735           
  Partials         448      448           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e311477...42b6a9d. Read the comment docs.

@jstarpl jstarpl merged commit ba3a75f into release41 Feb 17, 2022
@jstarpl jstarpl deleted the feat/noDefaultTabs branch February 17, 2022 13:11
@jstarpl jstarpl mentioned this pull request Mar 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants