feat!: no default tabs when using Shelf Layout #684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature change - this is a breaking change for anyone using Custom Shelf Layouts.
When custom Shelf Layout is used, AdLibs and Global AdLib tabs are still shown.
When a custom Shelf Layout is used, AdLibs and Global AdLibs tabs are not shown.
This PR refactors a lot of the AdLib Shelf List code to be more modular and use React Hooks whenever possible. Also, since these custom Tabs will now need to sometimes function as main AdLib and Global AdLib tabs, the rendering performance of this component has been increased through use of memoization. Some unused code was removed also. Also, regular Global AdLib panel has been refactored so that it's just an AdLib panel with a hard-coded filter. This should DRY the code out some.
Status