fix: OAuth code returned via redirect_uri #719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the OAuth authentication procedure used by the Spreadsheet Gateway.
Currently the Spreadsheet Gateway relies on the user approving access to their Google Drive, then copying and pasting a code from a page displayed by Google into a form hosted in Sofie.
Since this was first implemented, Google has deprecated (and subsequently removed) support for this copy-paste method of entering access codes. Instead, it is required that Sofie provides a callback url which can be provided with the code as a URL parameter.
Two new URL handlers have been added:
/devices/:deviceId/oauthResponse
/devices/:deviceId/resetAuth
There have also been a couple of QoL improvements made to the OAuth form, as well as removing references to "spreadsheet" to allow the form to be reused for other OAuth-based services.
Status