-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move blueprint ab logic into sofie SOFIE-2403 #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release50 #946 +/- ##
==============================================
- Coverage 80.86% 56.33% -24.53%
==============================================
Files 135 492 +357
Lines 26523 78225 +51702
Branches 2116 3874 +1758
==============================================
+ Hits 21448 44070 +22622
- Misses 5050 34105 +29055
- Partials 25 50 +25
☔ View full report in Codecov by Sentry. |
Julusian
changed the title
feat: move blueprint ab logic into sofie
feat: move blueprint ab logic into sofie SOFIE-2403
Jun 8, 2023
nytamin
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code quality: Skimmed it, looks good
- Unit tests exist
- Documentation has been updated
jstarpl
reviewed
Jun 9, 2023
packages/documentation/docs/for-developers/for-blueprint-developers/ab-playback.md
Show resolved
Hide resolved
jstarpl
reviewed
Jun 9, 2023
jstarpl
approved these changes
Jun 12, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
AB playback logic is 99% handled by blueprints in
onTimelineGenerate
. There are a couple of helper methods provided to deal with ids, the rest is left to blueprints to figure out themselves.All of this AB logic that blueprints used to have to implement, is now moved into the core of Sofie.
Blueprints can enable this AB logic by implementing the
getAbResolverConfiguration
method in the ShowStyle blueprint, which is where the pools are defined along with any rules on how to apply the player assignments to the timeline.Q) Should
abSession
be defined onPiece
orPieceGeneric
? There are complications risen due to needing to handle AB from adlib pieces, so perhaps we could take a stance of not supporting it?Status