Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: casparCG template transitions bug #225

Draft
wants to merge 1 commit into
base: release47
Choose a base branch
from

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Oct 18, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix.

CasparCG Templates doesn't actually support transitions, but we have code paths that support it (but apparently they are buggy).

  • What is the current behavior? (You can also link to an open issue here)
    When playing a template object, and (accidentally) has set a transition for it, the template isn't played properly.
    (when stopped, a PLAY "empty" is sent, not a CG STOP)

  • What is the new behavior (if this is a feature change)?
    CG PLAY and CG STOP are sent, as they should

  • Other information:

TODO

  • Verify that this is actually the right thing to do, and that templates actually does not and should not support transitions

Transitions for templates are not supported by Caspar nor CasparCG state
@mint-dewit
Copy link
Member

There is an edge case here when your template doesn't have an out transition and you want to do a fade out using the casparcg transitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants