-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HTTPSend): Add OAuth 2.0 and Bearer Token options #329
feat(HTTPSend): Add OAuth 2.0 and Bearer Token options #329
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release50 #329 +/- ##
=============================================
- Coverage 37.58% 37.36% -0.22%
=============================================
Files 106 107 +1
Lines 10247 10306 +59
Branches 2452 2511 +59
=============================================
Hits 3851 3851
- Misses 6395 6454 +59
Partials 1 1 ☔ View full report in Codecov by Sentry. |
}, | ||
"oauthTokenHost": { | ||
"type": "string", | ||
"ui:title": "OAuth 2.0 Token Host", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be useful to specify that this is the "base URL" of the oauth flow, i.e. the way the "token host" is described in the simple-oauth2
: "Base URL used to obtain access tokens". I don't think "token host" is a widely used term in the OAuth world. Also, specifying that this is in fact a URL (and not, say a hostname + path) would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made changes to the UI descriptions of this setting, and I added another field to allow specifying the path
Hello! Thank you for contributing to the Sofie Project! If you haven’t already, please give our contribution guidelines a read. I have found a a single usability-related issue, with the term "token host" that I would argue should be called something that contains a URL to specify that this is in fact a base URL for the OAauth flow. Once that's addressed, it should be merged within a few days. |
92af351
to
76592f2
Compare
Since release50 is feature-frozen and this is a new feature, I'll redirect this PR towards release51. |
About the Contributor
This PR is opened on behalf of TV 2 Norge,
Type of Contribution
This is a:
Feature
Current Behavior
Unless handled completely outside of the TSR, requests made through HTTPSend can't be authorized.
New Behavior
Two authorization methods are supported in the HTTPSend integration:
Testing Instructions
Other Information
Status