Fix/ab lookahead #231
Merged
Fix/ab lookahead #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytamin
approved these changes
May 25, 2020
Julusian
force-pushed
the
fix/ab-lookahead
branch
from
bb3141f
to
2baee3b
Compare
ianshade
pushed a commit
to ianshade/tv-automation-server-core
that referenced
this pull request
Jun 9, 2023
…_X_X SOF-1410 Move migrations away from X_X_X file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Some fixes useful for ab-playback
What is the current behavior? (You can also link to an open issue here)
Lookahead is not working for ab-playback, due to it being done via keyframes which are being stripped off by core.
What is the new behavior (if this is a feature change)?
Keyframes now have a property to say that they should be kept when run through lookahead.
Also a getCurrentTime method is added to the EventContext. This lets ab-playback know what the current time is and so it can make more intelligent decisions based on whether something is already on air or not.
Status