Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency of file commands #21

Merged
merged 2 commits into from
May 26, 2022
Merged

Conversation

turboencabulator
Copy link
Contributor

  • Remove a couple duplicate patterns in rm rules.
  • Remove the absolute path on some /bin/rm and /bin/cp commands.
  • Always use rm -f instead of rm || true or -rm (where the leading dash is Make syntax to ignore errors).
  • rmdir commands were using two error suppression methods (-rmdir || true), prefer rmdir || true since it is less noisy than -rmdir.
  • mkdir -p commands do not need parent directories supplied as arguments; add the -p flag if missing.

Remove absolute paths (/bin/rm, /bin/cp).
Use rm -f instead of ignoring errors (-rm, rm || true).
install-gzipped-man:
mkdir -p $(MAN) $(MANDIR) $(MAN7DIR)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove $(MAN) here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's defined as the parent directory of $(MANDIR) and $(MAN7DIR), and the -p flag will automatically create parent directories if necessary.

@nrnrnr nrnrnr merged commit 9784ac0 into nrnrnr:master May 26, 2022
@turboencabulator turboencabulator deleted the filecmd branch May 28, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants