Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outgoing caravans should default to full trades #167

Open
Endovior opened this issue Feb 22, 2020 · 1 comment
Open

Outgoing caravans should default to full trades #167

Endovior opened this issue Feb 22, 2020 · 1 comment

Comments

@Endovior
Copy link

Game version
0.2.7

Description
Currently, outgoing trade caravans default to selling 400 items, regardless of prices or capacity, unless the available quantity of the sold good is less than that. Ideally, I'd like them to default to making a full trade.

For example, I currently have two trading partners. One buys metal and sells food. The price they offer is 5 food for every 10 metal. That means my caravan will be coming back emptier than they left, so I can send out a full caravan with 750 metal and get back 375 food. In that situation I'd prefer to send out 750 metal by default.

The other trade partner buys rope and sells metal. The price they offer is 40 metal for every 10 rope. The capacity is the same, but the price difference means that they'll be going out emptier than they return. Also, it doesn't make sense to send out 400 rope when I can get 750 metal back by sending 190 rope (750 / 4 = 187.5; in units of 10, I need to send out 190 to get back a full trade). When trading with them, I'd prefer to send out 190 rope by default.

Determining just what these defaults should be for arbitrary prices would take a bit of calculation, but automatically trading to capacity would be a noticeable QoL improvement for the trading system.

@nroutasuo
Copy link
Owner

This is a good suggestion, I'll look into implementing it at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants