support dot in named params

nrstott · Oct 6, 2011 · adfe1b3 · adfe1b3
1 parent b9ef621
commit adfe1b3
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/lib/router.js b/lib/router.js
@@ -18,7 +18,7 @@ var
     UPDATE: httpMethod.PUT,
     DESTROY: httpMethod.DELETE
   },
-  PATH_PARAMETER_REPLACEMENT = "([^\.\/\?]+)",
+  PATH_PARAMETER_REPLACEMENT = "([^\/\?]+)",
   PATH_PARAMETERS = /:([\w\d]+)/g;
 
 exports.bogartEvent = {

diff --git a/test/router.test.js b/test/router.test.js
@@ -12,6 +12,16 @@ var bogart = require('../lib/bogart')
       env: {}
     };
  };
+
+function getMock(path) {
+  return {
+    headers: {},
+    pathInfo: path,
+    method: 'GET',
+    jsgi: { version: [0,3] },
+    env: {}
+  };
+}
 
 exports['test matches parameter'] = function(beforeExit) {
   var
@@ -213,3 +223,20 @@ exports['test should have X-Powered-By Bogart header'] = function(beforeExit) {
     assert.equal('Bogart', response.headers['X-Powered-By']);
   });
 };
+
+exports['test matches a dot (".") as part of a named param'] = function(beforeExit) {
+  var router
+    , foo = null;
+
+  router = bogart.router();
+  router.get('/:foo/:bar', function(req) {
+    foo = req.params.foo;
+  });
+
+  router(getMock('/user@example.com/name'));
+
+  beforeExit(function() {
+    assert.isNotNull(foo, 'Named parameter should not be null');
+    assert.equal('user@example.com', foo);
+  });
+};