fix: remove loading item from projects view #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 5cd7c67. Click to see the status, the terminal output, and the build insights. 馃搨 See all runs for this branch
Sent with 馃拰 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This removes the loading item from the projects view. This was causing some issues with some users where items were trying to be used before all the projects were loaded.
Initially this was added in this extension as a way to show that projects were loading (duh 馃槀) because the parser used originally was terribly slow, and the vscode ui froze. With the quicker parser, we don't freeze the UI anymore, and this loading item is not needed.
Potentially fixes #1126