Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replaced banner svg with png version to support vsce bundling #1234

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

Phillip9587
Copy link
Contributor

I missed that vsce does not support SVGs in README:

nps is executing `package.vscode` : shx rm -rf dist/apps/vscode/**/*-es5.js && node tools/scripts/vscode-vsce.js
ERROR  SVGs are restricted in README.md; please use other file image formats, such as PNG: https://raw.githubusercontent.com/nrwl/nx-console/master/static/nx-console-banner.svg

@nx-cloud
Copy link

nx-cloud bot commented Jan 26, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit c2af2ae. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@Cammisuli Cammisuli merged commit 82c8460 into nrwl:master Jan 26, 2022
@Phillip9587 Phillip9587 deleted the readme-updates branch January 26, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants