Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove favicon from bundle #1237

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

Phillip9587
Copy link
Contributor

@Phillip9587 Phillip9587 commented Jan 26, 2022

VS Code Webview icon is set in

webviewPanel.iconPath = {
light: Uri.file(
join(context.extensionPath, 'assets', 'nx-console-light.svg')
),
dark: Uri.file(
join(context.extensionPath, 'assets', 'nx-console-dark.svg')
),
};

favicon.ico is not needed.

@nx-cloud
Copy link

nx-cloud bot commented Jan 26, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 711d8a3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@Cammisuli Cammisuli changed the title fix: remove favicon from bundle chore: remove favicon from bundle Jan 28, 2022
@Cammisuli Cammisuli merged commit 59b61df into nrwl:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants