Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for duplicate collections based on type #1241

Merged

Conversation

Cammisuli
Copy link
Member

What it does

This makes sure that when we check for duplicate collections, we check the type as well. This fixes an issue where generators and executors have the same name, and one or the other gets filtered out.

@nx-cloud
Copy link

nx-cloud bot commented Feb 4, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 66eafec. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@Cammisuli Cammisuli merged commit 079bbb0 into nrwl:master Feb 4, 2022
@Cammisuli Cammisuli deleted the check-only-for-duplicate-collection-types branch February 4, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant