fix(vscode-ui): Correctly populate defaults #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmeku
commented
Nov 15, 2019
| @@ -294,7 +294,7 @@ export class TaskExecutionFormComponent implements OnInit, AfterViewChecked { | |||
| const defaultValues: { [key: string]: string } = {}; | |||
| architect.schema.forEach(field => { | |||
| defaultValues[field.name] = | |||
| field.defaultValue || field.type === 'boolean' ? 'false' : ''; | |||
| field.defaultValue || (field.type === 'boolean' ? 'false' : ''); | |||
There was a problem hiding this comment.
Stupid order or operations
mrmeku
force-pushed
the
default-variables
branch
from
76305a7
to
7cb20e8
Compare
jaysoo
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes parsing defaults from angular json
Fixes setting defaults from schematic fields (many were appearing as false)
Fixes setting default for select menus