Skip to content

Commit

Permalink
feat(react-native): upgrade @storybook/react-native to 6.0.1-beta.11 (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
xiongemi committed Jan 23, 2023
1 parent 578f5c0 commit 0a1e744
Show file tree
Hide file tree
Showing 4 changed files with 38 additions and 12 deletions.
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { configure, getStorybookUI } from '@storybook/react-native';

import { loadStories } from '../../../../.storybook/story-loader';
import { loadStories } from '<%= offsetFromRoot %>../.storybook/story-loader';

configure(loadStories(), module, false);
configure(() => loadStories(), module);

const StorybookUIRoot = getStorybookUI({});
const StorybookUIRoot = getStorybookUI();

export default StorybookUIRoot;
export default StorybookUIRoot;
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@ export async function createStorybookFiles(
);

// do not proceed if not a react native project
if (targets?.start?.executor !== '@nrwl/react-native:start') {
if (
targets?.start?.executor !== '@nrwl/react-native:start' &&
targets?.start?.executor !== '@nrwl/expo:start'
) {
logger.error(
`Unable to add storybook to ${schema.name}. It is not a Nx React Native / Expo project.`
);
return;
}

Expand All @@ -33,7 +39,7 @@ export async function createStorybookFiles(

if (host.exists(storybookUIFilePath)) {
logger.warn(
`${storybookUIFileName} file already exists for React Native ${projectType} ${schema.name}! Skipping generating this file.`
`${storybookUIFileName} file already exists for ${projectType} ${schema.name}! Skipping generating this file.`
);
return;
}
Expand All @@ -45,10 +51,6 @@ export async function createStorybookFiles(
);
}

const projectDirectory = projectType === 'application' ? 'app' : 'lib';

logger.debug(`Adding storybook file to React Native app ${projectDirectory}`);

// copy files to app's .storybook folder
generateFiles(
host,
Expand All @@ -57,7 +59,6 @@ export async function createStorybookFiles(
{
tmpl: '',
offsetFromRoot: offsetFromRoot(sourceRoot),
projectType: projectDirectory,
}
);

Expand Down
25 changes: 25 additions & 0 deletions packages/storybook/migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,31 @@
}
},
"packageJsonUpdates": {
"15.5.2": {
"version": "15.5.2-beta.0",
"packages": {
"@storybook/react-native": {
"version": "^6.0.1-beta.11",
"alwaysAddToPackageJson": false
},
"@storybook/addon-ondevice-actions": {
"version": "^6.0.1-beta.11",
"alwaysAddToPackageJson": false
},
"@storybook/addon-ondevice-backgrounds": {
"version": "^6.0.1-beta.11",
"alwaysAddToPackageJson": false
},
"@storybook/addon-ondevice-controls": {
"version": "^6.0.1-beta.11",
"alwaysAddToPackageJson": false
},
"@storybook/addon-ondevice-notes": {
"version": "^6.0.1-beta.11",
"alwaysAddToPackageJson": false
}
}
},
"15.4.3": {
"version": "15.4.3-beta.1",
"packages": {
Expand Down
2 changes: 1 addition & 1 deletion packages/storybook/src/utils/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const svgrVersion = '^5.4.0';
export const urlLoaderVersion = '^3.0.0';
export const webpack5Version = '^5.64.0';
export const viteBuilderVersion = '^0.2.6';
export const storybookReactNativeVersion = '^6.0.1-beta.9';
export const storybookReactNativeVersion = '^6.0.1-beta.11';
export const reactNativeStorybookLoader = '^2.0.5';
export const storybookSwcAddonVersion = '^1.1.7';
export const storybookNextAddonVersion = '^1.6.6';
Expand Down

0 comments on commit 0a1e744

Please sign in to comment.