Skip to content

Commit

Permalink
chore(storybook): added storybook 7 testing suite
Browse files Browse the repository at this point in the history
  • Loading branch information
mandarini committed Mar 17, 2023
1 parent 5244e48 commit 0c9f791
Show file tree
Hide file tree
Showing 9 changed files with 434 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/e2e-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ jobs:
- e2e-web
- e2e-rollup
- e2e-storybook
- e2e-storybook-7
- e2e-vite
- e2e-webpack
- e2e-workspace-create
Expand Down Expand Up @@ -141,6 +142,8 @@ jobs:
codeowners: 'S04SJ6PL98X'
- project: e2e-storybook
codeowners: 'S04SVQ8H0G5'
- project: e2e-storybook-7
codeowners: 'S04SVQ8H0G5'
- project: e2e-vite
codeowners: 'S04SJ6PL98X'
- project: e2e-webpack
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/e2e-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
- e2e-web
- e2e-rollup
- e2e-storybook
- e2e-storybook-7
- e2e-vite
- e2e-webpack
- e2e-workspace-create
Expand Down Expand Up @@ -117,6 +118,8 @@ jobs:
- project: e2e-rollup
codeowners: 'S04SJ6PL98X'
- project: e2e-storybook
codeowners: 'S04SVQ8H0G5'
- project: e2e-storybook-7
codeowners: 'S04SVQ8H0G5'
- project: e2e-vite
codeowners: 'S04SJ6PL98X'
Expand Down
24 changes: 24 additions & 0 deletions docs/shared/mental-model/large-tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -36176,6 +36176,30 @@
},
"dependencies": { "e2e-storybook:run-e2e-tests": [] }
},
"e2e-storybook-7:e2e": {
"roots": ["e2e-storybook-7:e2e"],
"tasks": {
"e2e-storybook-7:e2e": {
"id": "e2e-storybook-7:e2e",
"target": { "project": "e2e-storybook-7", "target": "e2e" },
"projectRoot": "e2e/storybook-7",
"overrides": {}
}
},
"dependencies": { "e2e-storybook-7:e2e": [] }
},
"e2e-storybook-7:run-e2e-tests": {
"roots": ["e2e-storybook-7:run-e2e-tests"],
"tasks": {
"e2e-storybook-7:run-e2e-tests": {
"id": "e2e-storybook-7:run-e2e-tests",
"target": { "project": "e2e-storybook-7", "target": "run-e2e-tests" },
"projectRoot": "e2e/storybook-7",
"overrides": {}
}
},
"dependencies": { "e2e-storybook-7:run-e2e-tests": [] }
},
"nx-dev:build": {
"roots": ["graph-client:build-base:release"],
"tasks": {
Expand Down
11 changes: 11 additions & 0 deletions e2e/storybook-7/jest.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
/* eslint-disable */
export default {
transform: {
'^.+\\.[tj]sx?$': ['ts-jest', { tsconfig: '<rootDir>/tsconfig.spec.json' }],
},
moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'html'],
maxWorkers: 1,
globals: {},
displayName: 'e2e-storybook-7',
preset: '../../jest.preset.js',
};
11 changes: 11 additions & 0 deletions e2e/storybook-7/project.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "e2e-storybook-7",
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "e2e/storybook-7",
"projectType": "application",
"targets": {
"e2e": {},
"run-e2e-tests": {}
},
"implicitDependencies": ["storybook"]
}
141 changes: 141 additions & 0 deletions e2e/storybook-7/src/storybook-7-nested.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
import {
checkFilesExist,
cleanupProject,
killPorts,
readJson,
runCLI,
runCommandUntil,
runCreateWorkspace,
tmpProjPath,
uniq,
} from '@nrwl/e2e/utils';
import { writeFileSync } from 'fs';

describe('Storybook generators and executors for standalone workspaces - using React + Vite', () => {
const wsName = uniq('react');
const appName = uniq('app');

beforeAll(() => {
// create a workspace with a single react app at the root
runCreateWorkspace(wsName, {
preset: 'react-standalone',
appName,
style: 'css',
bundler: 'vite',
});

runCLI(
`generate @nrwl/react:storybook-configuration ${appName} --storybook7Configuration --generateStories --no-interactive`
);

runCLI(`report`);
});

afterAll(() => {
cleanupProject();
});

describe('Storybook generated files', () => {
it('should generate storybook files', () => {
checkFilesExist(
'.storybook/main.js',
'.storybook/preview.js',
'.storybook/tsconfig.json'
);
});

it('should edit root tsconfig.json', () => {
const tsconfig = readJson(`tsconfig.json`);
expect(tsconfig['ts-node']?.compilerOptions?.module).toEqual('commonjs');
});

it('should generate correct files for nested app', () => {
const nestedAppName = uniq('other-app');
runCLI(`generate @nrwl/react:app ${nestedAppName} --no-interactive`);
runCLI(
`generate @nrwl/react:storybook-configuration ${nestedAppName} --storybook7Configuration --generateStories --no-interactive`
);
checkFilesExist(
`apps/${nestedAppName}/.storybook/main.js`,
`apps/${nestedAppName}/.storybook/tsconfig.json`
);
});
});

describe('serve storybook', () => {
afterEach(() => killPorts());

it('should serve a React based Storybook setup that uses Vite', async () => {
const p = await runCommandUntil(`run ${appName}:storybook`, (output) => {
return /Storybook.*started/gi.test(output);
});
p.kill();
}, 1000000);
});

describe('build storybook', () => {
it('should build a React based storybook that uses Vite', () => {
runCLI(`run ${appName}:build-storybook --verbose`);
checkFilesExist(`dist/storybook/${appName}/index.html`);
}, 1000000);

// This test makes sure path resolution works
it('should build a React based storybook that references another lib and uses Vite', () => {
const reactLib = uniq('test-lib-react');
runCLI(`generate @nrwl/react:lib ${reactLib} --no-interactive`);
// create a React component we can reference
writeFileSync(
tmpProjPath(`${reactLib}/src/lib/mytestcmp.tsx`),
`
import React from 'react';
/* eslint-disable-next-line */
export interface MyTestCmpProps {}
export const MyTestCmp = (props: MyTestCmpProps) => {
return (
<div>
<h1>Welcome to test cmp!</h1>
</div>
);
};
export default MyTestCmp;
`
);
// update index.ts and export it
writeFileSync(
tmpProjPath(`${reactLib}/src/index.ts`),
`
export * from './lib/mytestcmp';
`
);

// create a story in the first lib to reference the cmp from the 2nd lib
writeFileSync(
tmpProjPath(`${reactLib}/src/lib/myteststory.stories.tsx`),
`
import React from 'react';
import { MyTestCmp, MyTestCmpProps } from '@${wsName}/${reactLib}';
export default {
component: MyTestCmp,
title: 'MyTestCmp',
};
export const primary = () => {
/* eslint-disable-next-line */
const props: MyTestCmpProps = {};
return <MyTestCmp />;
};
`
);

// build React lib
runCLI(`run ${reactLib}:build-storybook --verbose`);
checkFilesExist(`dist/storybook/${reactLib}/index.html`);
}, 1000000);
});
});
Loading

0 comments on commit 0c9f791

Please sign in to comment.