fix(angular): show actionable error when component resource is not fo…

…und in ng-packagr executors (#15217)
nrwl · Feb 24, 2023 · 12fff86 · 12fff86
1 parent 8a58cdd
commit 12fff86
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/...es/angular/src/executors/ng-packagr-lite/ng-packagr-adjustments/ts/cache-compiler-host.ts b/...es/angular/src/executors/ng-packagr-lite/ng-packagr-adjustments/ts/cache-compiler-host.ts
@@ -174,6 +174,10 @@ export function cacheCompilerHost(
 
       const cache = sourcesFileCache.getOrCreate(fileName);
       if (cache.content === undefined) {
+        if (!compilerHost.fileExists(fileName)) {
+          throw new Error(`Cannot read file ${fileName}.`);
+        }
+
         if (/(?:html?|svg)$/.test(path.extname(fileName))) {
           // template
           cache.content = compilerHost.readFile.call(this, fileName);
@@ -185,10 +189,6 @@ export function cacheCompilerHost(
           });
         }
 
-        if (cache.content === undefined) {
-          throw new Error(`Cannot read file ${fileName}.`);
-        }
-
         cache.exists = true;
       }
 

diff --git a/packages/angular/src/executors/package/ng-packagr-adjustments/ts/cache-compiler-host.ts b/packages/angular/src/executors/package/ng-packagr-adjustments/ts/cache-compiler-host.ts
@@ -198,6 +198,10 @@ export function cacheCompilerHost(
 
       const cache = sourcesFileCache.getOrCreate(fileName);
       if (cache.content === undefined) {
+        if (!compilerHost.fileExists(fileName)) {
+          throw new Error(`Cannot read file ${fileName}.`);
+        }
+
         if (/(?:html?|svg)$/.test(path.extname(fileName))) {
           // template
           cache.content = compilerHost.readFile.call(this, fileName);
@@ -209,10 +213,6 @@ export function cacheCompilerHost(
           });
         }
 
-        if (cache.content === undefined) {
-          throw new Error(`Cannot read file ${fileName}.`);
-        }
-
         cache.exists = true;
       }