fix(storybook): path on Win for tsconfig location in angular.json

ISSUES CLOSED: #3956
nrwl · Nov 13, 2020 · 1bf5bf4 · 1bf5bf4
1 parent da77047
commit 1bf5bf4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/storybook/src/migrations/update-10-3-0/update-10-3-0.spec.ts b/packages/storybook/src/migrations/update-10-3-0/update-10-3-0.spec.ts
@@ -168,7 +168,7 @@ describe('Update 10-3-0', () => {
             \\"path\\": \\"./tsconfig.spec.json\\"
           },
           {
-            \\"path\\": \\"./.storybook/tsconfig.json\\"
+            \\"path\\": \\".storybook/tsconfig.json\\"
           }
         ]
       }
@@ -220,7 +220,7 @@ describe('Update 10-3-0', () => {
             \\"path\\": \\"./tsconfig.spec.json\\"
           },
           {
-            \\"path\\": \\"./.storybook/tsconfig.json\\"
+            \\"path\\": \\".storybook/tsconfig.json\\"
           }
         ]
       }

diff --git a/packages/storybook/src/migrations/update-10-3-0/update-10-3-0.ts b/packages/storybook/src/migrations/update-10-3-0/update-10-3-0.ts
@@ -13,6 +13,7 @@ import {
 } from '@nrwl/workspace';
 
 import { getTsConfigContent, isFramework } from '../../utils/utils';
+import { normalize } from '@angular-devkit/core';
 
 interface ProjectDefinition {
   root: string;
@@ -55,9 +56,8 @@ function updateLintTarget(
   const paths = {
     tsConfig: path.join(options.projectConfig.root, 'tsconfig.json'),
     tsConfigLib: path.join(options.projectConfig.root, 'tsconfig.lib.json'),
-    tsConfigStorybook: path.join(
-      options.projectConfig.root,
-      '.storybook/tsconfig.json'
+    tsConfigStorybook: normalize(
+      path.join(options.projectConfig.root, '.storybook/tsconfig.json')
     ),
   };
 
@@ -102,7 +102,9 @@ function updateLintTarget(
       (ref) => ref.path !== './.storybook/tsconfig.json'
     )
   ) {
-    tsConfig.main.references.push({ path: './.storybook/tsconfig.json' });
+    tsConfig.main.references.push({
+      path: normalize('./.storybook/tsconfig.json'),
+    });
     tree.overwrite(paths.tsConfig, serializeJson(tsConfig.main));
   }