Skip to content

Commit

Permalink
fix(angular): ensure buildable libraries in-process tsconfig file ext…
Browse files Browse the repository at this point in the history
…ends from the correct path (#23165)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #23091
  • Loading branch information
leosvelperez committed May 3, 2024
1 parent e5c0206 commit 1d2c843
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
DependentBuildableProjectNode,
} from '@nx/js/src/utils/buildable-libs-utils';
import { NgPackagr } from 'ng-packagr';
import { resolve } from 'path';
import { join, resolve } from 'path';
import { createLibraryExecutor } from '../package/package.impl';
import type { BuildAngularLibraryExecutorOptions } from '../package/schema';
import { parseRemappedTsConfigAndMergeDefaults } from '../utilities/typescript';
Expand All @@ -20,7 +20,7 @@ async function initializeNgPackgrLite(

if (options.tsConfig) {
const remappedTsConfigFilePath = createTmpTsConfig(
options.tsConfig,
join(context.root, options.tsConfig),
context.root,
context.projectsConfigurations.projects[context.projectName].root,
projectDependencies
Expand Down
4 changes: 2 additions & 2 deletions packages/angular/src/executors/package/package.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
type DependentBuildableProjectNode,
} from '@nx/js/src/utils/buildable-libs-utils';
import type { NgPackagr } from 'ng-packagr';
import { resolve } from 'path';
import { join, resolve } from 'path';
import { from } from 'rxjs';
import { mapTo, switchMap } from 'rxjs/operators';
import { parseRemappedTsConfigAndMergeDefaults } from '../utilities/typescript';
Expand All @@ -24,7 +24,7 @@ async function initializeNgPackagr(

if (options.tsConfig) {
const remappedTsConfigFilePath = createTmpTsConfig(
options.tsConfig,
join(context.root, options.tsConfig),
context.root,
context.projectsConfigurations.projects[context.projectName].root,
projectDependencies
Expand Down

0 comments on commit 1d2c843

Please sign in to comment.