fix(testing): fix generating cypress-project with no project specified

nrwl · May 30, 2020 · 3263174 · 3263174
1 parent 606ad29
commit 3263174
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/packages/cypress/src/schematics/cypress-project/cypress-project.spec.ts b/packages/cypress/src/schematics/cypress-project/cypress-project.spec.ts
@@ -221,5 +221,20 @@ describe('schematic:cypress-project', () => {
         );
       });
     });
+
+    describe('--project', () => {
+      describe('none', () => {
+        it('should not add any implicit dependencies', async () => {
+          const tree = await runSchematic(
+            'cypress-project',
+            { name: 'my-app-e2e' },
+            appTree
+          );
+
+          const nxJson = readJsonInTree(tree, 'nx.json');
+          expect(nxJson.projects['my-app-e2e']).toEqual({ tags: [] });
+        });
+      });
+    });
   });
 });
diff --git a/packages/cypress/src/schematics/cypress-project/cypress-project.ts b/packages/cypress/src/schematics/cypress-project/cypress-project.ts
@@ -51,8 +51,14 @@ function updateNxJson(options: CypressProjectSchema): Rule {
   return updateJsonInTree<NxJson>('nx.json', (json) => {
     json.projects[options.projectName] = {
       tags: [],
-      implicitDependencies: [options.project],
     };
+
+    if (options.project) {
+      json.projects[options.projectName].implicitDependencies = [
+        options.project,
+      ];
+    }
+
     return json;
   });
 }