feat(testing): remove --watch=false from inferred vitest targets to k…

…eep things inlined with vitest recommendations
nrwl · May 23, 2024 · 4ec254e · 4ec254e
1 parent 94707d9
commit 4ec254e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/e2e/vite/src/vite-crystal.test.ts b/e2e/vite/src/vite-crystal.test.ts
@@ -49,7 +49,7 @@ describe('@nx/vite/plugin', () => {
       }, 200_000);
 
       it('should test application', () => {
-        const result = runCLI(`test ${myApp}`);
+        const result = runCLI(`test ${myApp} --watch=false`);
         expect(result).toContain('Successfully ran target test');
       }, 200_000);
     });
@@ -60,7 +60,7 @@ describe('@nx/vite/plugin', () => {
       }, 200_000);
 
       it('should test application', () => {
-        const result = runCLI(`test ${myVueApp}`);
+        const result = runCLI(`test ${myVueApp} --watch=false`);
         expect(result).toContain('Successfully ran target test');
       }, 200_000);
     });

diff --git a/packages/vite/src/plugins/__snapshots__/plugin-vitest.spec.ts.snap b/packages/vite/src/plugins/__snapshots__/plugin-vitest.spec.ts.snap
@@ -17,10 +17,12 @@ exports[`@nx/vite/plugin root project should create nodes 1`] = `
                 "vitest",
               ],
             },
+            {
+              "env": "CI",
+            },
           ],
           "options": {
             "cwd": ".",
-            "watch": false,
           },
           "outputs": [
             "{projectRoot}/coverage",

diff --git a/packages/vite/src/plugins/__snapshots__/plugin-with-test.spec.ts.snap b/packages/vite/src/plugins/__snapshots__/plugin-with-test.spec.ts.snap
@@ -17,10 +17,12 @@ exports[`@nx/vite/plugin with test node root project should create nodes - with
                 "vitest",
               ],
             },
+            {
+              "env": "CI",
+            },
           ],
           "options": {
             "cwd": ".",
-            "watch": false,
           },
           "outputs": [
             "{projectRoot}/coverage",

diff --git a/packages/vite/src/plugins/plugin.ts b/packages/vite/src/plugins/plugin.ts
@@ -216,7 +216,7 @@ async function testTarget(
 ) {
   return {
     command: `vitest`,
-    options: { cwd: joinPathFragments(projectRoot), watch: false },
+    options: { cwd: joinPathFragments(projectRoot) },
     cache: true,
     inputs: [
       ...('production' in namedInputs
@@ -225,6 +225,7 @@ async function testTarget(
       {
         externalDependencies: ['vitest'],
       },
+      { env: 'CI' },
     ],
     outputs,
   };