Skip to content

Commit

Permalink
chore(core): remove which
Browse files Browse the repository at this point in the history
  • Loading branch information
Cammisuli committed Mar 16, 2023
1 parent a72e067 commit 5038b20
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 14 deletions.
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@
"@types/semver": "^7.3.8",
"@types/tar-stream": "^2.2.2",
"@types/tmp": "^0.2.0",
"@types/which": "^2.0.2",
"@types/yargs": "^17.0.10",
"@types/yarnpkg__lockfile": "^1.1.5",
"@typescript-eslint/eslint-plugin": "5.38.1",
Expand Down Expand Up @@ -315,8 +314,7 @@
"tailwindcss": "3.2.4",
"tslib": "^2.3.0",
"vitest": "^0.25.8",
"weak-napi": "^2.0.2",
"which": "^3.0.0"
"weak-napi": "^2.0.2"
},
"resolutions": {
"**/xmlhttprequest-ssl": "~1.6.2",
Expand All @@ -336,3 +334,4 @@
]
}
}

1 change: 0 additions & 1 deletion packages/nx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"tsconfig-paths": "^4.1.2",
"tslib": "^2.3.0",
"v8-compile-cache": "2.3.0",
"which": "^3.0.0",
"yargs": "^17.6.2",
"yargs-parser": "21.1.1"
},
Expand Down
7 changes: 2 additions & 5 deletions packages/nx/src/daemon/client/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { ensureDirSync, ensureFileSync } from 'fs-extra';
import { connect } from 'net';
import { join } from 'path';
import { performance } from 'perf_hooks';
import * as which from 'which';
import { output } from '../../utils/output';
import { FULL_OS_SOCKET_PATH, killSocketOrPath } from '../socket-utils';
import {
Expand Down Expand Up @@ -325,11 +324,9 @@ export class DaemonClient {

this._out = await open(DAEMON_OUTPUT_LOG_FILE, 'a');
this._err = await open(DAEMON_OUTPUT_LOG_FILE, 'a');
// Find the node path based on the path.
// This allows us to use the node version based on the host os, rather than other host processes
const nodeExecutable = await which('node');

const backgroundProcess = spawn(
nodeExecutable,
process.execPath,
[join(__dirname, '../server/start.js')],
{
cwd: workspaceRoot,
Expand Down
5 changes: 0 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8047,11 +8047,6 @@
anymatch "^3.0.0"
source-map "^0.6.0"

"@types/which@^2.0.2":
version "2.0.2"
resolved "https://registry.yarnpkg.com/@types/which/-/which-2.0.2.tgz#54541d02d6b1daee5ec01ac0d1b37cecf37db1ae"
integrity sha512-113D3mDkZDjo+EeUEHCFy0qniNc1ZpecGiAU7WSo7YDoSzolZIQKpYFHrPpjkB2nuyahcKfrmLXeQlh7gqJYdw==

"@types/ws@^8.5.1":
version "8.5.3"
resolved "https://registry.yarnpkg.com/@types/ws/-/ws-8.5.3.tgz#7d25a1ffbecd3c4f2d35068d0b283c037003274d"
Expand Down

0 comments on commit 5038b20

Please sign in to comment.