Skip to content

Commit

Permalink
fix(webpack): set module: true for swcMinify
Browse files Browse the repository at this point in the history
  • Loading branch information
jaysoo committed Sep 18, 2023
1 parent fcf5b9c commit 52df963
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions e2e/web/src/web.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ describe('Web Components Applications', () => {
beforeEach(() => newProject());
afterEach(() => cleanupProject());

// TODO Re-enable this when it is passing.
xit('should be able to generate a web app', async () => {
it('should be able to generate a web app', async () => {
const appName = uniq('app');
runCLI(
`generate @nx/web:app ${appName} --bundler=webpack --no-interactive`
Expand Down
1 change: 1 addition & 0 deletions packages/webpack/src/utils/with-nx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ export function withNx(pluginOptions?: WithNxOptions): NxWebpackPlugin {
minify: TerserPlugin.swcMinify,
// `terserOptions` options will be passed to `swc`
terserOptions: {
module: true,
mangle: false,
},
}),
Expand Down

0 comments on commit 52df963

Please sign in to comment.